Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 1255573005: Create FrameNavigationEntries for the initial blank page in subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests and move has_committed_real_load Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index 9159a11244b9384c12eb62cb395dddceed9f0647..df3413c8d9574185287dc1862b509fc7a3c04671 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -414,12 +414,6 @@ NavigationControllerImpl::GetEntryWithUniqueID(int nav_entry_id) const {
return (index != -1) ? entries_[index] : nullptr;
}
-bool NavigationControllerImpl::HasCommittedRealLoad(
- FrameTreeNode* frame_tree_node) const {
- NavigationEntryImpl* last_committed = GetLastCommittedEntry();
- return last_committed && last_committed->GetFrameEntry(frame_tree_node);
-}
-
void NavigationControllerImpl::LoadEntry(
scoped_ptr<NavigationEntryImpl> entry) {
// When navigating to a new page, we don't know for sure if we will actually

Powered by Google App Engine
This is Rietveld 408576698