Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 1255573005: Create FrameNavigationEntries for the initial blank page in subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 113
114 // Return the entry with the corresponding instance and page_id, or null if 114 // Return the entry with the corresponding instance and page_id, or null if
115 // not found. 115 // not found.
116 NavigationEntryImpl* GetEntryWithPageID( 116 NavigationEntryImpl* GetEntryWithPageID(
117 SiteInstance* instance, 117 SiteInstance* instance,
118 int32 page_id) const; 118 int32 page_id) const;
119 119
120 // Return the entry with the given unique id, or null if not found. 120 // Return the entry with the given unique id, or null if not found.
121 NavigationEntryImpl* GetEntryWithUniqueID(int nav_entry_id) const; 121 NavigationEntryImpl* GetEntryWithUniqueID(int nav_entry_id) const;
122 122
123 // Whether the given frame has committed any navigations yet.
124 // This currently only returns true in --site-per-process mode.
125 // TODO(creis): Create FrameNavigationEntries by default so this always works.
126 bool HasCommittedRealLoad(FrameTreeNode* frame_tree_node) const;
127
128 NavigationControllerDelegate* delegate() const { 123 NavigationControllerDelegate* delegate() const {
129 return delegate_; 124 return delegate_;
130 } 125 }
131 126
132 // For use by WebContentsImpl ------------------------------------------------ 127 // For use by WebContentsImpl ------------------------------------------------
133 128
134 // Allow renderer-initiated navigations to create a pending entry when the 129 // Allow renderer-initiated navigations to create a pending entry when the
135 // provisional load starts. 130 // provisional load starts.
136 void SetPendingEntry(scoped_ptr<NavigationEntryImpl> entry); 131 void SetPendingEntry(scoped_ptr<NavigationEntryImpl> entry);
137 132
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 TimeSmoother time_smoother_; 440 TimeSmoother time_smoother_;
446 441
447 scoped_ptr<NavigationEntryScreenshotManager> screenshot_manager_; 442 scoped_ptr<NavigationEntryScreenshotManager> screenshot_manager_;
448 443
449 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl); 444 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl);
450 }; 445 };
451 446
452 } // namespace content 447 } // namespace content
453 448
454 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 449 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/frame_tree_node.cc ('k') | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698