Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2435)

Unified Diff: chrome/test/data/pdf/viewport_test.js

Issue 1255403002: Add a scroll offset to PDF documents to account for the top material design toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/pdf/viewport_test.js
diff --git a/chrome/test/data/pdf/viewport_test.js b/chrome/test/data/pdf/viewport_test.js
index a513de939715ea3ab3f8aa7d2b350216da0df236..a0dea27646f9dd8e70f6cda192311ff136ed7359 100644
--- a/chrome/test/data/pdf/viewport_test.js
+++ b/chrome/test/data/pdf/viewport_test.js
@@ -491,6 +491,48 @@ var tests = [
chrome.test.assertEq(2, viewport.zoom);
chrome.test.succeed();
},
+
+ function testToolbarHeightOffset() {
+ var mockSizer = new MockSizer();
+ var mockWindow = new MockWindow(100, 100);
+ var viewport = new Viewport(mockWindow,
+ mockSizer, function() {}, function() {}, function() {}, 0, 1);
+ viewport.topToolbarHeight = 50;
+ var documentDimensions = new MockDocumentDimensions(0, 0);
+ documentDimensions.addPage(50, 500);
+ viewport.setDocumentDimensions(documentDimensions);
+ viewport.setZoom(1);
+
+ // Check that the sizer incorporates the toolbar height.
+ chrome.test.assertEq('550px', mockSizer.style.height);
+ chrome.test.assertEq('50px', mockSizer.style.width);
+ chrome.test.assertEq(0, viewport.position.x);
+
+ // Check the sizer incorporates the toolbar height correctly even if zoomed.
+ viewport.setZoom(2);
+ chrome.test.assertEq('1050px', mockSizer.style.height);
+ chrome.test.assertEq('100px', mockSizer.style.width);
+
+ // Test that the viewport scrolls to the correct offset when fit-to-page is
+ // enabled. The top of the viewport should be at the start of the document.
+ viewport.fitToPage();
+ chrome.test.assertEq(0, viewport.position.y);
+
+ // Check that going to a page scrolls to the correct offset when fit-to-page
+ // is enabled. The top of the viewport should be at the start of the
+ // document.
+ mockWindow.scrollTo(0, 100);
+ viewport.goToPage(0);
+ chrome.test.assertEq(0, viewport.position.y);
+
+ // Check that going to a page scrolls to the correct offset when fit-to-page
+ // is not enabled. The top of the viewport should be before start of the
+ // document.
+ viewport.setZoom(1);
+ viewport.goToPage(0);
+ chrome.test.assertEq(-50, viewport.position.y);
+ chrome.test.succeed();
+ }
];
chrome.test.runTests(tests);

Powered by Google App Engine
This is Rietveld 408576698