Add a scroll offset to PDF documents to account for the top material design toolbar.

Add a scroll offset to PDF documents to account for the top material design toolbar.

Previously the toolbar in the material design PDF UI would always cover the top
of pages when it was first loaded or when a page was navigated to using the
page selector. Now we ensure that a blank region is left at the very top of
the document when it is first loaded. This is the region that the toolbar
covers, so the document is not obscured at all. When pages are navigated to, we
ensure that the top of the selected page is always underneath the toolbar
so that it is not obscured. The one exception to this is when in fit-to-page
mode which causes the page to be zoomed to cover the entire screen, ignoring
the toolbar. This is so that users can take advantaging of filling all of the
screen real-estate with a page when that is what they want.

This is implemented by initially scrolling the document to a negative offset
(which is equal to the toolbar height). All subsequent scrolls are relative
to this initial scroll. A few small bugs that assumed there was no blank space
above the first page have also been fixed.

BUG=439114
Committed: https://crrev.com/daad0f1f879b13c8b55797ae5ce106d382283047
Cr-Commit-Position: refs/heads/master@{#341685}

Committed: https://crrev.com/bd82a94bbc1738c60459dec25f4d9aa73f7baeab
Cr-Commit-Position: refs/heads/master@{#341861}

[raymes, 2015-07-28 05:54:33]

raymes@chromium.org changed reviewers:
+ sammc@chromium.org, tsergeant@chromium.org

[raymes, 2015-08-03 07:31:28]

PTAL

[raymes, 2015-08-03 07:31:57]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-03 07:32:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1255403002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1255403002/60001

[Sam McNally, 2015-08-03 08:06:45]

https://codereview.chromium.org/1255403002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/pdf/viewport.js (right):

https://codereview.chromium.org/1255403002/diff/60001/chrome/browser/resource...
chrome/browser/resources/pdf/viewport.js:48: this.topToolbarHeight = 0;
Please make this a constructor param instead of a public attribute.

https://codereview.chromium.org/1255403002/diff/60001/chrome/browser/resource...
chrome/browser/resources/pdf/viewport.js:496: // Unless we're in fit to page
mode, scroll a bit above the page so that
Can you be a bit more precise than "a bit above"?

https://codereview.chromium.org/1255403002/diff/60001/pdf/out_of_process_inst...
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/1255403002/diff/60001/pdf/out_of_process_inst...
pdf/out_of_process_instance.cc:599: // are 0-based (they do not correspond to
the viewports coordinates in JS).
s/viewports/viewport's/
This line should end in a comma.

[commit-bot: I haz the power, 2015-08-03 09:01:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-03 09:01:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[raymes, 2015-08-04 00:28:46]

https://codereview.chromium.org/1255403002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/pdf/viewport.js (right):

https://codereview.chromium.org/1255403002/diff/60001/chrome/browser/resource...
chrome/browser/resources/pdf/viewport.js:48: this.topToolbarHeight = 0;
On 2015/08/03 08:06:45, Sam McNally wrote:
> Please make this a constructor param instead of a public attribute.

Done.

https://codereview.chromium.org/1255403002/diff/60001/chrome/browser/resource...
chrome/browser/resources/pdf/viewport.js:496: // Unless we're in fit to page
mode, scroll a bit above the page so that
On 2015/08/03 08:06:45, Sam McNally wrote:
> Can you be a bit more precise than "a bit above"?

Done.

https://codereview.chromium.org/1255403002/diff/60001/pdf/out_of_process_inst...
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/1255403002/diff/60001/pdf/out_of_process_inst...
pdf/out_of_process_instance.cc:599: // are 0-based (they do not correspond to
the viewports coordinates in JS).
On 2015/08/03 08:06:45, Sam McNally wrote:
> s/viewports/viewport's/
> This line should end in a comma.

Done.

[raymes, 2015-08-04 00:28:50]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-04 00:29:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1255403002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1255403002/80001

[Sam McNally, 2015-08-04 00:48:55]

LGTM

https://codereview.chromium.org/1255403002/diff/80001/pdf/out_of_process_inst...
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/1255403002/diff/80001/pdf/out_of_process_inst...
pdf/out_of_process_instance.cc:600: // JS), so we need to subtract the toolbar
height to convert thme into
them

[raymes, 2015-08-04 01:00:20]

https://codereview.chromium.org/1255403002/diff/80001/pdf/out_of_process_inst...
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/1255403002/diff/80001/pdf/out_of_process_inst...
pdf/out_of_process_instance.cc:600: // JS), so we need to subtract the toolbar
height to convert thme into
On 2015/08/04 00:48:55, Sam McNally wrote:
> them

Done.

[raymes, 2015-08-04 01:00:24]

The CQ bit was checked by raymes@chromium.org

[raymes, 2015-08-04 01:00:24]

The patchset sent to the CQ was uploaded after l-g-t-m from sammc@chromium.org
Link to the patchset: https://codereview.chromium.org/1255403002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-08-04 01:01:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1255403002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1255403002/120001

[commit-bot: I haz the power, 2015-08-04 05:05:47]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-08-04 05:07:38]

Patchset 7 (id:??) landed as
https://crrev.com/daad0f1f879b13c8b55797ae5ce106d382283047
Cr-Commit-Position: refs/heads/master@{#341685}

[Vitaly Buka (NO REVIEWS), 2015-08-04 21:42:50]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1267553004/ by vitalybuka@chromium.org.

The reason for reverting is: This patch breaks print preview.

BUG=516829.

[raymes, 2015-08-05 05:54:06]

The CQ bit was checked by raymes@chromium.org

[raymes, 2015-08-05 05:54:06]

The patchset sent to the CQ was uploaded after l-g-t-m from sammc@chromium.org
Link to the patchset: https://codereview.chromium.org/1255403002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-08-05 05:54:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1255403002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1255403002/140001

[commit-bot: I haz the power, 2015-08-05 07:06:55]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-08-05 07:09:09]

Patchset 8 (id:??) landed as
https://crrev.com/bd82a94bbc1738c60459dec25f4d9aa73f7baeab
Cr-Commit-Position: refs/heads/master@{#341861}