Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tests/lib/async/run_async4_test.dart

Issue 12554008: Update status file. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/lib/lib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/async/run_async4_test.dart
diff --git a/tests/lib/async/run_async4_test.dart b/tests/lib/async/run_async4_test.dart
index 1c105205a897b90c41c7d18dca569636abca96e8..46967dfcf1ec9b15556cd4c3c84e62569eccd2c2 100644
--- a/tests/lib/async/run_async4_test.dart
+++ b/tests/lib/async/run_async4_test.dart
@@ -17,10 +17,6 @@ void startTest(SendPort finishPort, replyPort) {
if (i == 50) throw new RuntimeError("ignore exception");
});
}
-
- // Without this Timer the isolate will freeze.
- // TODO(9013): Remove this Timer.
- new Timer(const Duration(seconds: 2), () { });
}
runTest() {
@@ -33,7 +29,9 @@ bool globalErrorHandler(IsolateUnhandledException e) {
main() {
var port = new ReceivePort();
+ var timer;
SendPort otherIsolate = spawnFunction(runTest, globalErrorHandler);
otherIsolate.send(port.toSendPort());
- port.receive((msg, replyPort) { port.close(); });
-}
+ port.receive((msg, replyPort) { port.close(); timer.cancel(); });
+ timer = new Timer(const Duration(seconds: 2), () { throw "failed"; });
+}
« no previous file with comments | « no previous file | tests/lib/lib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698