Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1255383004: [compiler] Verify that type feedback vector structure is the same on recompile. (Closed)

Created:
5 years, 4 months ago by mvstanton
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Verify that type feedback vector structure is the same on recompile. Use a CHECK statement to find any violations of this rule. Committed: https://crrev.com/99a53f73235c73f04035e960750e3f1b3ece60f7 Cr-Commit-Position: refs/heads/master@{#29965}

Patch Set 1 #

Patch Set 2 : Fix. #

Patch Set 3 : REBASE. #

Patch Set 4 : REBASE and comment change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/compiler.cc View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mvstanton
Hi Benedikt, here is the bug we were looking at...
5 years, 4 months ago (2015-07-28 07:04:05 UTC) #2
Benedikt Meurer
LGTM. Hope that helps to find the root causes...
5 years, 4 months ago (2015-07-28 07:07:39 UTC) #3
mvstanton
Hi guys, As per discussion with Jakob, we'll want to check this in next Monday. ...
5 years, 4 months ago (2015-07-30 10:58:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255383004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255383004/60001
5 years, 4 months ago (2015-08-03 07:51:58 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-03 08:14:47 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 08:15:00 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/99a53f73235c73f04035e960750e3f1b3ece60f7
Cr-Commit-Position: refs/heads/master@{#29965}

Powered by Google App Engine
This is Rietveld 408576698