Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: src/IceCfg.cpp

Issue 1255303004: Add -reorder-basic-blocks option and fix nop insertion (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: rebase to master branch Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceCfg.h ('k') | src/IceCfgNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceCfg.cpp
diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp
index ef49c155f615cb2ad1e2c2998aa1cb1f9f47bfa8..c19d01a464020bc5ce4c9d5750f7907531a82293 100644
--- a/src/IceCfg.cpp
+++ b/src/IceCfg.cpp
@@ -371,6 +371,51 @@ void Cfg::reorderNodes() {
assert(Nodes.size() == OldSize);
}
+namespace {
+void getRandomPostOrder(CfgNode *Node, llvm::BitVector &ToVisit,
+ Ice::NodeList &PostOrder,
+ Ice::RandomNumberGenerator *RNG) {
+ assert(ToVisit[Node->getIndex()]);
+ ToVisit[Node->getIndex()] = false;
+ NodeList Outs = Node->getOutEdges();
+ Ice::RandomShuffle(Outs.begin(), Outs.end(),
+ [RNG](int N) { return RNG->next(N); });
+ for (CfgNode *Next : Outs) {
+ if (ToVisit[Next->getIndex()])
+ getRandomPostOrder(Next, ToVisit, PostOrder, RNG);
+ }
+ PostOrder.push_back(Node);
+}
+} // end of anonymous namespace
+
+void Cfg::shuffleNodes() {
+ if (!Ctx->getFlags().shouldReorderBasicBlocks())
+ return;
+
+ NodeList ReversedReachable;
+ NodeList Unreachable;
+ llvm::BitVector ToVisit(Nodes.size(), true);
+ // Traverse from entry node.
+ getRandomPostOrder(getEntryNode(), ToVisit, ReversedReachable,
+ &Ctx->getRNG());
+ // Collect the unreachable nodes.
+ for (CfgNode *Node : Nodes)
+ if (ToVisit[Node->getIndex()])
+ Unreachable.push_back(Node);
+ // Copy the layout list to the Nodes.
+ SizeT OldSize = Nodes.size();
+ (void)OldSize;
+ Nodes.clear();
+ for (CfgNode *Node : reverse_range(ReversedReachable))
+ Nodes.emplace_back(Node);
+ for (CfgNode *Node : Unreachable) {
+ Nodes.emplace_back(Node);
+ }
+ assert(Nodes.size() == OldSize);
+
+ dump("After basic block shuffling");
+}
+
void Cfg::doArgLowering() {
TimerMarker T(TimerStack::TT_doArgLowering, this);
getTarget()->lowerArguments();
@@ -383,6 +428,8 @@ void Cfg::doAddressOpt() {
}
void Cfg::doNopInsertion() {
+ if (!Ctx->getFlags().shouldDoNopInsertion())
+ return;
TimerMarker T(TimerStack::TT_doNopInsertion, this);
for (CfgNode *Node : Nodes)
Node->doNopInsertion();
« no previous file with comments | « src/IceCfg.h ('k') | src/IceCfgNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698