Simplify base64 streaming decoder, drop decoding check.

test/base64_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Library tag to allow the test to run on Dartium.
 library base64_test;
 
 import 'dart:math';
 import 'dart:async';
 
 import "package:crypto/crypto.dart";
 import "package:test/test.dart";
 
 void main() {
   test('encoder', _testEncoder);
   test('decoder', _testDecoder);
   test('decoder for malformed input', _testDecoderForMalformedInput);
   test('encode decode lists', _testEncodeDecodeLists);
   test('url safe encode-decode', _testUrlSafeEncodeDecode);
-  test('consistent safe/unsafe character decoding',
-       _testConsistentSafeUnsafeDecode);
   test('percent-encoded padding character encode-decode',
        _testPaddingCharacter);
   test('streaming encoder', _testStreamingEncoder);
   test('streaming decoder', _testStreamingDecoder);
   test('streaming decoder for malformed input',
        _testStreamingDecoderForMalformedInput);
   test('streaming encoder for different decompositions of a list of bytes',
        _testStreamingEncoderForDecompositions);
   test('streaming decoder for different decompositions of a string',
        _testStreamingDecoderForDecompositions);
-  test('consistent safe/unsafe character streaming decoding',
-       _testConsistentSafeUnsafeStreamDecode);
   test('streaming for encoded padding character',
        _testStreamingForEncodedPadding);
   test('old api', _testOldApi);
   test('url safe streaming encoder/decoder', _testUrlSafeStreaming);
   test('performance', _testPerformance);
 
 
 }
 
 // Data from http://tools.ietf.org/html/rfc4648.
@@ skipping 33 matching lines @@
     [[196], [], [16], [], [], [158], [], [196]],
     [[196], [], [16], [158, 196], [], []],
     [[], [196], [], [], [16, 158], [], [196]],
     [[], [196], [16, 158, 196], []],
     [[196, 16, 158], [], [], [196]],
     [[196, 16, 158], [], [196], []],
     [[196, 16, 158, 196], [], [], []]];
 
 const _DECOMPOSITION_ENCODED = 'xBCexA==';
 
 const _INCONSISTENT_SAFE_RESULT = 'A+_x';

[Søren Gjesse, 2015/08/05 07:18:33]

Remove this constant and the next as well.

 
 const _INCONSISTENT_SAFE_STREAMING_RESULT = const ['A+AAA', '_x='];
 
 // Test data with only zeroes.
 var inputsWithZeroes = [[0, 0, 0], [0, 0], [0], []];
 const _RESULTS_WITH_ZEROS = const ['AAAA', 'AAA=', 'AA==', ''];
 
 const _LONG_LINE =
     "Man is distinguished, not only by his reason, but by this singular "
     "passion from other animals, which is a lust of the mind, that by a "
@@ skipping 132 matching lines @@
 
 Future _testUrlSafeStreaming() async {
   String encUrlSafe = '-_A=';
   List<List<int>> dec = [BASE64.decode('+/A=')];
   var streamedResult = await new Stream.fromIterable(dec)
       .transform(new Base64Encoder(urlSafe: true)).join();
 
   expect(streamedResult, encUrlSafe);
 }
 
-void _testConsistentSafeUnsafeDecode() {
-  expect(() {
-    BASE64.decode(_INCONSISTENT_SAFE_RESULT);
-  }, throwsFormatException);
-}
-
-Future _testConsistentSafeUnsafeStreamDecode() {
-  expect(new Stream.fromIterable(_INCONSISTENT_SAFE_STREAMING_RESULT)
-                   .transform(BASE64.decoder)
-                   .toList(),
-         throwsFormatException);
-}
-
 Future _testStreamingForEncodedPadding() async {
   List<String> withEncodedPadding = ['AA%', '3D', '%', '3', 'DEFGZ'];
   List<int> decoded = BASE64.decode('AA==EFGZ');
   var streamedResult = await new Stream.fromIterable(withEncodedPadding)
       .transform(BASE64.decoder).expand((x) => x).toList();
 
   expect(streamedResult, decoded);
 }
 
 void _testUrlSafeEncodeDecode() {
@@ skipping 46 matching lines @@
     // print("Encode 1024 bytes for $iters times: $ms msec. $perSec b/s");
     w..reset();
     for( int i = 0; i < iters; ++i ) {
       BASE64.decode(enc);
     }
     ms = w.elapsedMilliseconds;
     perSec = (iters * l.length) * 1000 ~/ ms;
     // ('''Decode into ${l.length} bytes for $iters
     //     times: $ms msec. $perSec b/s''');
 }