base/message_loop/message_pump_libevent.h - Issue 1255293006: Microoptimisation for OnLibeventNotification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/message_loop/message_pump_libevent.h

Issue 1255293006: Microoptimisation for OnLibeventNotification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try to improve readability by separating the cases. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/message_loop/message_pump_libevent.h

diff --git a/base/message_loop/message_pump_libevent.h b/base/message_loop/message_pump_libevent.h

index 3f5ad51dae91d8a7f3f7017ab3968281e6ee6ce3..c285d966f41308b31559e61bc1005422697d8a5a 100644

--- a/base/message_loop/message_pump_libevent.h

+++ b/base/message_loop/message_pump_libevent.h

@@ -86,7 +86,9 @@ class BASE_EXPORT MessagePumpLibevent : public MessagePump {

event* event_;

MessagePumpLibevent* pump_;

Watcher* watcher_;

- WeakPtrFactory<FileDescriptorWatcher> weak_factory_;

+ // If this pointer is non-NULL, the pointee is set to true in the

+ // destructor.

+ bool* was_destroyed_;

DISALLOW_COPY_AND_ASSIGN(FileDescriptorWatcher);

};