Issue 1255253004: Fix various typos, error handling for GN auto-roller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1255253004: Fix various typos, error handling for GN auto-roller. (Closed)

Created:
5 years, 4 months ago by Dirk Pranke

Modified:
5 years, 4 months ago

Reviewers:
tfarina, brettw

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix various typos, error handling for GN auto-roller. R=brettw@chromium.org Committed: https://crrev.com/68ae5bcd387dbed627ed0053f3de1be188016938 Cr-Commit-Position: refs/heads/master@{#340777}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -13 lines)			Patch
	M	tools/gn/bin/roll_gn.py	View		7 chunks	+31 lines, -13 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Dirk Pranke

With this set of fixes, the script ran through an entire roll correctly.

5 years, 4 months ago (2015-07-28 00:25:57 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255253004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255253004/1

5 years, 4 months ago (2015-07-28 21:46:29 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-07-28 22:00:30 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/68ae5bcd387dbed627ed0053f3de1be188016938
Cr-Commit-Position: refs/heads/master@{#340777}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages