Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 125523002: android2grd tool now puts <outputs> element first. (Closed)

Created:
6 years, 11 months ago by newt (away)
Modified:
6 years, 11 months ago
Reviewers:
Nico, Jói
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

android2grd tool now puts <outputs> element first. By convention, most grd files have the <outputs> element first, followed by <translations> and then <release>. This updates the android2grd tool to follow that order. R=thakis@chromium.org Committed: https://code.google.com/p/grit-i18n/source/detail?r=143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M grit/tool/android2grd.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
newt (away)
joi: for background, see the discussion here https://chromiumcodereview.appspot.com/11829009/#msg9
6 years, 11 months ago (2014-01-06 23:12:19 UTC) #1
newt (away)
Note: after this change the android2grd unit tests still pass
6 years, 11 months ago (2014-01-06 23:14:31 UTC) #2
Nico
lgtm Thanks!
6 years, 11 months ago (2014-01-06 23:23:51 UTC) #3
newt (away)
6 years, 11 months ago (2014-01-07 15:08:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r143 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698