Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1255213003: Add Tracing.requestMemoryDump method stub to DevTools API (Closed)

Created:
5 years, 4 months ago by petrcermak
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, jam, yurys, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Tracing.requestMemoryDump method stub to DevTools API This patch is the first part of a 3-sided patch which adds Tracing.requestMemoryDump method to DevTools API: 1. Add Tracing.requestMemoryDump method stub to DevTools API this patch [Chromium] 2. Add Tracing.requestMemoryDump method to DevTools API (protocol) https://codereview.chromium.org/1235393005/ [Blink] 3. Add Tracing.requestMemoryDump method to DevTools API (tracing handler) https://codereview.chromium.org/1232313004/ [Chromium] Proposal: https://docs.google.com/document/d/190-URzSjfsiXNeyke86z85-5ctuqsC_RoX1J1uJTwIQ/edit?usp=sharing BUG=505826 Committed: https://crrev.com/4fea05d9046efdd564d6a29ae82d8472fc366f9a Cr-Commit-Position: refs/heads/master@{#340553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/devtools/protocol/tracing_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/tracing_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
petrcermak
PTAL. Thanks, Petr
5 years, 4 months ago (2015-07-27 18:06:17 UTC) #2
pfeldman
lgtm, yes, that's the sequence of landing until repos merge.
5 years, 4 months ago (2015-07-27 18:53:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255213003/1
5 years, 4 months ago (2015-07-27 18:55:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 20:41:49 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 20:43:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fea05d9046efdd564d6a29ae82d8472fc366f9a
Cr-Commit-Position: refs/heads/master@{#340553}

Powered by Google App Engine
This is Rietveld 408576698