Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1255183002: [test] Replace android_commands in v8 perf runner. (Closed)

Created:
5 years, 4 months ago by Michael Achenbach
Modified:
5 years, 4 months ago
Reviewers:
ulan, jbudorick
CC:
jbudorick, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Replace android_commands in v8 perf runner. BUG=chromium:267773 LOG=n NOTRY=true Committed: https://crrev.com/2fdebc0407bebdfb73c50c0abbbe6992863ec843 Cr-Commit-Position: refs/heads/master@{#29875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M tools/run_perf.py View 4 chunks +10 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Achenbach
PTAL
5 years, 4 months ago (2015-07-27 13:39:58 UTC) #2
ulan
lgtm
5 years, 4 months ago (2015-07-27 13:44:59 UTC) #3
jbudorick
lgtm
5 years, 4 months ago (2015-07-27 14:01:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255183002/1
5 years, 4 months ago (2015-07-27 14:55:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 14:56:59 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 14:57:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fdebc0407bebdfb73c50c0abbbe6992863ec843
Cr-Commit-Position: refs/heads/master@{#29875}

Powered by Google App Engine
This is Rietveld 408576698