Introduce safe interface to "copy and grow" FixedArray.

Introduce safe interface to "copy and grow" FixedArray.

This introduces a CopyFixedArrayAndGrow method on Factory that takes
the "grow amount" instead of the "new size" as an argument. The new
interface is safer because it allows for mutations by the GC that
potentially trim the source array.

This also fixes a bug in SharedFunctionInfo::AddToOptimizedCodeMap
where the aformentioned scenario led to unused entries within the
optimized code map.

Note that FixedArray::CopySize is hereby deprecated because it is
considered unsafe and should no longer be used.

R=hpayer@chromium.org
TEST=mjsunit/regress/regress-crbug-513507
BUG=chromium:513507
LOG=n

Committed: https://crrev.com/bcad9b547d00320f818ce6ff08016a02ce0b6e5b
Cr-Commit-Position: refs/heads/master@{#30012}

[Hannes Payer (out of office), 2015-08-04 16:34:19]

lgtm, and one cctest please with verified states.

[Michael Starzinger, 2015-08-04 16:52:25]

One cctest coming right up. Still warm out of the printer. PTAL.

[Hannes Payer (out of office), 2015-08-04 16:57:38]

lgtm, with 2 nits

https://codereview.chromium.org/1255173006/diff/20001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/1255173006/diff/20001/test/cctest/test-heap.c...
test/cctest/test-heap.cc:4528: // Prepare optimize code that we can use.
optimized

https://codereview.chromium.org/1255173006/diff/20001/test/cctest/test-heap.c...
test/cctest/test-heap.cc:4546: #ifdef DEBUG
Let's move it up, because the test is otherwise not doing much.

[Michael Starzinger, 2015-08-04 17:02:58]

https://codereview.chromium.org/1255173006/diff/20001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/1255173006/diff/20001/test/cctest/test-heap.c...
test/cctest/test-heap.cc:4528: // Prepare optimize code that we can use.
On 2015/08/04 16:57:38, Hannes Payer wrote:
> optimized

Done.

https://codereview.chromium.org/1255173006/diff/20001/test/cctest/test-heap.c...
test/cctest/test-heap.cc:4546: #ifdef DEBUG
On 2015/08/04 16:57:38, Hannes Payer wrote:
> Let's move it up, because the test is otherwise not doing much.

Done.

[Michael Starzinger, 2015-08-04 17:18:03]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-08-04 17:18:03]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1255173006/#ps20002
(title: "Addressed nits.")

[commit-bot: I haz the power, 2015-08-04 17:18:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1255173006/20002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1255173006/20002

[commit-bot: I haz the power, 2015-08-04 17:49:38]

Committed patchset #3 (id:20002)

[commit-bot: I haz the power, 2015-08-04 17:49:53]

Patchset 3 (id:??) landed as
https://crrev.com/bcad9b547d00320f818ce6ff08016a02ce0b6e5b
Cr-Commit-Position: refs/heads/master@{#30012}