Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1255153002: Debugger: do not reject data parsed in the background when debugging. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@fix
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: do not reject data parsed in the background when debugging. This has become possible since we never compile for debugging in the first compile pass of a script. R=vogelheim@chromium.org BUG=chromium:513335 LOG=N Committed: https://crrev.com/f67455174b20bc6f1275b8c8d727f067478d53d3 Cr-Commit-Position: refs/heads/master@{#29874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Yang
5 years, 4 months ago (2015-07-27 12:51:03 UTC) #1
vogelheim
lgtm
5 years, 4 months ago (2015-07-27 12:54:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255153002/1
5 years, 4 months ago (2015-07-27 13:54:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 14:20:00 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 14:20:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f67455174b20bc6f1275b8c8d727f067478d53d3
Cr-Commit-Position: refs/heads/master@{#29874}

Powered by Google App Engine
This is Rietveld 408576698