Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1255133002: [stubs] Properly handle read-only properties in StoreGlobalViaContextStub. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Properly handle read-only properties in StoreGlobalViaContextStub. We don't need the hole check and slow runtime mode for read-only properties this way. R=ishell@chromium.org Committed: https://crrev.com/cac64b9f634743f7f5311d4dca8d50157b10fab5 Cr-Commit-Position: refs/heads/master@{#29881}

Patch Set 1 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -54 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +8 lines, -12 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M src/objects.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M src/property-details.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +11 lines, -9 lines 0 comments Download
M test/mjsunit/regress/cross-script-vars.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
5 years, 4 months ago (2015-07-27 08:31:11 UTC) #1
Benedikt Meurer
Hey Igor, Here's the optimization we were talking about this morning. Basically we can handle ...
5 years, 4 months ago (2015-07-27 08:41:34 UTC) #2
Igor Sheludko
lgtm
5 years, 4 months ago (2015-07-27 18:43:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255133002/40001
5 years, 4 months ago (2015-07-27 18:44:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 4 months ago (2015-07-27 18:45:32 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 18:45:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cac64b9f634743f7f5311d4dca8d50157b10fab5
Cr-Commit-Position: refs/heads/master@{#29881}

Powered by Google App Engine
This is Rietveld 408576698