Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1255123006: Revert of Net: Stop treating partial HTTP headers as a valid response. (Closed)

Created:
5 years, 4 months ago by Zhenyao Mo
Modified:
5 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Net: Stop treating partial HTTP headers as a valid response. (patchset #7 id:160001 of https://codereview.chromium.org/1266713007/ ) Reason for revert: Might broke http/tests/security/XFrameOptions/x-frame-options-cached.html http/tests/security/contentSecurityPolicy/cached-frame-csp.html http/tests/security/xssAuditor/cached-frame.html on windows blink bots Original issue's description: > Net: Stop treating partial HTTP headers as a valid response. > > For now, we return ERR_RESPONSE_HEADERS_TRUNCATED in this case. Longer > term, we probably want to get rid of the extra code to detect when this > happens. > > Also do a bit of cleanup in HttpStreamParser's error handling code. > > BUG=472762 > > Committed: https://crrev.com/854d9c86cc897fdf55ea917d2aed2070e9235dac > Cr-Commit-Position: refs/heads/master@{#341744} TBR=davidben@chromium.org,thestig@chromium.org,jyasskin@chromium.org,mmenke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=472762 Committed: https://crrev.com/9528c9f4b7200659c10da799aaface62c19af91b Cr-Commit-Position: refs/heads/master@{#341809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -97 lines) Patch
M chrome/browser/chrome_service_worker_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 4 chunks +44 lines, -39 lines 0 comments Download
M net/http/http_stream_parser.cc View 2 chunks +39 lines, -30 lines 0 comments Download
M net/http/http_stream_parser_unittest.cc View 1 chunk +47 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Zhenyao Mo
Created Revert of Net: Stop treating partial HTTP headers as a valid response.
5 years, 4 months ago (2015-08-04 22:07:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255123006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255123006/1
5 years, 4 months ago (2015-08-04 22:08:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 22:12:18 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9528c9f4b7200659c10da799aaface62c19af91b Cr-Commit-Position: refs/heads/master@{#341809}
5 years, 4 months ago (2015-08-04 22:17:31 UTC) #4
Zhenyao Mo
5 years, 4 months ago (2015-08-04 22:23:29 UTC) #5
Message was sent while issue was closed.
Sample failure run:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/33322

Powered by Google App Engine
This is Rietveld 408576698