Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1255113004: Revert of Add output reference to gen written files. (Closed)

Created:
5 years, 4 months ago by Dirk Pranke
Modified:
5 years, 4 months ago
Reviewers:
Peter Mayo, brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add output reference to gen written files. (patchset #3 id:40001 of https://codereview.chromium.org/1220223002/) Reason for revert: Looks like this doesn't quite work on Windows: http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/21206/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > Add output reference to gen written files. > > By adding the outputs written at gn gen time to the build.ninja representation the build tool (ninja) can know how to recreate them if and when necessary. > > For example, if one or more of the <blah>.tmp files is removed, even as part of an entire hierarchy/subtree currently the build fails because ninja does not know how to re-make it. > > BUG=469621 > TEST=Build time only. See https://code.google.com/p/chromium/issues/detail?id=469621#c3 > > Committed: https://crrev.com/517ac52f86903beb206b19e6ddeedbc709b253a1 > Cr-Commit-Position: refs/heads/master@{#338929} TBR=brettw@chromium.org,petermayo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=469621 Committed: https://crrev.com/61fb6826c8e7b9a31c260cb3698258e4fad5b33b Cr-Commit-Position: refs/heads/master@{#340596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M tools/gn/function_write_file.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/gn/ninja_build_writer.cc View 1 chunk +4 lines, -13 lines 0 comments Download
M tools/gn/scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/scheduler.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dirk Pranke
Created Revert of Add output reference to gen written files.
5 years, 4 months ago (2015-07-27 23:08:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255113004/1
5 years, 4 months ago (2015-07-27 23:09:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 23:10:38 UTC) #3
Peter Mayo
LGTM Sigh.
5 years, 4 months ago (2015-07-27 23:10:47 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/61fb6826c8e7b9a31c260cb3698258e4fad5b33b Cr-Commit-Position: refs/heads/master@{#340596}
5 years, 4 months ago (2015-07-27 23:11:24 UTC) #5
Dirk Pranke
On 2015/07/27 23:11:24, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 4 months ago (2015-07-27 23:12:37 UTC) #6
Peter Mayo
5 years, 4 months ago (2015-07-28 22:18:36 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1252403005/ by petermayo@chromium.org.

The reason for reverting is: Start Reland Issue.

Powered by Google App Engine
This is Rietveld 408576698