Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1255103003: Fix race when reloading original URL. (Closed)

Created:
5 years, 4 months ago by lfg
Modified:
5 years, 4 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2454
Target Ref:
refs/pending/branch-heads/2454
Project:
chromium
Visibility:
Public.

Description

Fix race when reloading original URL. Fixes an issue where the browser's last committed entry and the renderer can become out of sync when reloading the original requested URL, which causes the browser to kill the renderer process. BUG=491861 TBR=creis@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1189413005 Cr-Commit-Position: refs/heads/master@{#338864} (cherry picked from commit 573e8be6d639b7066a270ae99d02e829e10b90dd)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -40 lines) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 2 chunks +76 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_request.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 8 chunks +34 lines, -19 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255103003/1
5 years, 4 months ago (2015-07-28 15:19:21 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years, 4 months ago (2015-07-28 15:19:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255103003/1
5 years, 4 months ago (2015-07-28 15:21:48 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 15:23:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698