Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1255083004: media: Mojo interfaces renaming. (Closed)

Created:
5 years, 4 months ago by xhwang
Modified:
5 years, 4 months ago
Reviewers:
jam, DaleCurtis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Mojo interfaces renaming. Now media mojo interfaces are in media::interfaces module, there's no need to prefix interfaces/structs with "Media" anymore. Details: MediaRenderer -> Renderer MediaRendererClient -> RendererClient MediaDecoderBuffer -> DecoderBuffer TBR=jam@chromium.org BUG=481599 TEST=Renaming only. Committed: https://crrev.com/b2498ce87e13227b4ca46662a8b88a5add6e9482 Cr-Commit-Position: refs/heads/master@{#340537}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -169 lines) Patch
M components/html_viewer/media_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 1 comment Download
M media/mojo/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/decryptor.mojom View 2 chunks +4 lines, -4 lines 0 comments Download
M media/mojo/interfaces/demuxer_stream.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
D media/mojo/interfaces/media_renderer.mojom View 1 chunk +0 lines, -55 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + media/mojo/interfaces/renderer.mojom View 2 chunks +4 lines, -4 lines 0 comments Download
M media/mojo/interfaces/service_factory.mojom View 1 chunk +4 lines, -4 lines 0 comments Download
M media/mojo/services/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/media_apptest.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M media/mojo/services/media_type_converters.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/mojo/services/media_type_converters.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M media/mojo/services/media_type_converters_unittest.cc View 5 chunks +5 lines, -9 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_demuxer_stream_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/mojo/services/mojo_renderer_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.h View 3 chunks +11 lines, -12 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.cc View 6 chunks +12 lines, -14 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 4 chunks +12 lines, -13 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/service_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/service_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/test/pipeline_integration_test.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
xhwang
PTAL
5 years, 4 months ago (2015-07-27 18:47:18 UTC) #2
DaleCurtis
lgtm
5 years, 4 months ago (2015-07-27 18:48:55 UTC) #3
xhwang
5 years, 4 months ago (2015-07-27 18:51:19 UTC) #5
xhwang
TBRing jam@chromium.org on trivial changes in components/html_viewer/media_factory.cc and content/renderer/render_frame_impl.cc
5 years, 4 months ago (2015-07-27 18:52:11 UTC) #6
xhwang
https://codereview.chromium.org/1255083004/diff/1/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/1255083004/diff/1/content/renderer/render_frame_impl.cc#newcode4993 content/renderer/render_frame_impl.cc:4993: nullptr, nullptr); This fixes a build failure left by ...
5 years, 4 months ago (2015-07-27 18:53:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255083004/1
5 years, 4 months ago (2015-07-27 18:55:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 19:55:44 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 19:56:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2498ce87e13227b4ca46662a8b88a5add6e9482
Cr-Commit-Position: refs/heads/master@{#340537}

Powered by Google App Engine
This is Rietveld 408576698