Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1255043003: Revert of Activate preserving of optimized code map accross GCs. (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Activate preserving of optimized code map accross GCs. (patchset #1 id:1 of https://codereview.chromium.org/1217863006/) Reason for revert: This CL may be the reason for the spike on memory corruption. Tentatively reverting this CL. BUG=chromium:512780 LOG=n Original issue's description: > Activate preserving of optimized code map accross GCs. > > This enables --noflush-optimized-code-cache which allows preserving > entries in the optimized code map accross GCs. This only applies to > values being reachable through other paths. > > R=hpayer@chromium.org,hablich@chromium.org > > Committed: https://crrev.com/1a8776db25b63c4ce718423772d1fd13f58eeab5 > Cr-Commit-Position: refs/heads/master@{#29755} TBR=hablich@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/4b6770867a08fe96b7643e4fee6de1a5c01a1ae9 Cr-Commit-Position: refs/heads/master@{#29888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
Created Revert of Activate preserving of optimized code map accross GCs.
5 years, 4 months ago (2015-07-28 07:27:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255043003/1
5 years, 4 months ago (2015-07-28 07:27:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 07:28:09 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 07:28:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b6770867a08fe96b7643e4fee6de1a5c01a1ae9
Cr-Commit-Position: refs/heads/master@{#29888}

Powered by Google App Engine
This is Rietveld 408576698