Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1255043002: Remove old TODO and commented-out DCHECK in Isolate::RunMicrotasks (Closed)

Created:
5 years, 5 months ago by adamk
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove old TODO and commented-out DCHECK in Isolate::RunMicrotasks Per discussion on the bug, the DCHECK'd case actually occurs in normal operation, outside of V8's control. BUG=chromium:388244 LOG=n Committed: https://crrev.com/6f4c0614d56087ef68345af967d8585166262b66 Cr-Commit-Position: refs/heads/master@{#29877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M src/isolate.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
adamk
5 years, 5 months ago (2015-07-25 00:03:05 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-07-27 08:52:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255043002/1
5 years, 4 months ago (2015-07-27 15:35:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4483)
5 years, 4 months ago (2015-07-27 15:38:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255043002/1
5 years, 4 months ago (2015-07-27 15:41:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 15:58:32 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 15:58:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f4c0614d56087ef68345af967d8585166262b66
Cr-Commit-Position: refs/heads/master@{#29877}

Powered by Google App Engine
This is Rietveld 408576698