Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: Source/core/dom/Node.h

Issue 125503002: We should unify various forms of tree traversal in DOM (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix the comments in TreeNode.h to be more descriptive Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/dom/NodeTraversal.h » ('j') | Source/wtf/TreeNode.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 164
165 virtual ~Node(); 165 virtual ~Node();
166 166
167 // DOM methods & attributes for Node 167 // DOM methods & attributes for Node
168 168
169 bool hasTagName(const QualifiedName&) const; 169 bool hasTagName(const QualifiedName&) const;
170 virtual String nodeName() const = 0; 170 virtual String nodeName() const = 0;
171 virtual String nodeValue() const; 171 virtual String nodeValue() const;
172 virtual void setNodeValue(const String&); 172 virtual void setNodeValue(const String&);
173 virtual NodeType nodeType() const = 0; 173 virtual NodeType nodeType() const = 0;
174 // FIXME: We should get rid of parentNode() usage and replace with parent()
175 // to bring us inline with the API of other tree structures in the codebase.
176 ContainerNode* parent() const { return parentNode(); }
174 ContainerNode* parentNode() const; 177 ContainerNode* parentNode() const;
175 Element* parentElement() const; 178 Element* parentElement() const;
176 Node* previousSibling() const { return m_previous; } 179 Node* previousSibling() const { return m_previous; }
177 Node* nextSibling() const { return m_next; } 180 Node* nextSibling() const { return m_next; }
178 PassRefPtr<NodeList> childNodes(); 181 PassRefPtr<NodeList> childNodes();
179 Node* firstChild() const; 182 Node* firstChild() const;
180 Node* lastChild() const; 183 Node* lastChild() const;
181 184
182 // ChildNode interface API 185 // ChildNode interface API
183 Element* previousElementSibling() const; 186 Element* previousElementSibling() const;
(...skipping 734 matching lines...) Expand 10 before | Expand all | Expand 10 after
918 921
919 } // namespace WebCore 922 } // namespace WebCore
920 923
921 #ifndef NDEBUG 924 #ifndef NDEBUG
922 // Outside the WebCore namespace for ease of invocation from gdb. 925 // Outside the WebCore namespace for ease of invocation from gdb.
923 void showTree(const WebCore::Node*); 926 void showTree(const WebCore::Node*);
924 void showNodePath(const WebCore::Node*); 927 void showNodePath(const WebCore::Node*);
925 #endif 928 #endif
926 929
927 #endif 930 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/NodeTraversal.h » ('j') | Source/wtf/TreeNode.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698