Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1255013002: Split off a separate --harmony_sloppy_let flag (Closed)

Created:
5 years, 5 months ago by Dan Ehrenberg
Modified:
5 years, 5 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Split off a separate --harmony_sloppy_let flag --harmony_sloppy includes behavior to turn on sloppy mode lexical bindings. Before this patch, it also included a way to parse let which is likely web-incompatible (let is disallowed as an identifier). This patch splits off the let parsing from the more general block scoping code, so that block scoping can be developed independently. R=adamk LOG=N BUG=v8:3305 Committed: https://crrev.com/2d2b72f6382df11056fb9c39da0581be85510459 Cr-Commit-Position: refs/heads/master@{#29855}

Patch Set 1 #

Patch Set 2 : Fix flags on mjsunit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M src/bootstrapper.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/parser.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/preparser.h View 4 chunks +4 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +4 lines, -1 line 0 comments Download
M test/mjsunit/harmony/block-conflicts-sloppy.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/block-const-assign-sloppy.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/block-for-sloppy.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/block-leave-sloppy.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/block-let-crankshaft-sloppy.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/block-let-declaration-sloppy.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/block-let-semantics-sloppy.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/block-scoping-sloppy.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/block-scoping-top-level-sloppy.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Dan Ehrenberg
5 years, 5 months ago (2015-07-24 22:31:53 UTC) #1
adamk
lgtm
5 years, 5 months ago (2015-07-24 22:36:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255013002/20001
5 years, 5 months ago (2015-07-24 23:18:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-25 00:05:14 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-25 00:05:24 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d2b72f6382df11056fb9c39da0581be85510459
Cr-Commit-Position: refs/heads/master@{#29855}

Powered by Google App Engine
This is Rietveld 408576698