Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: runtime/vm/json_stream.h

Issue 1255003003: Make VM service id handling JSON-RPC 2 compliant. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: cr Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/server.dart ('k') | runtime/vm/json_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/json_stream.h
diff --git a/runtime/vm/json_stream.h b/runtime/vm/json_stream.h
index d314dbf62eae1cafa5bb861be4d802132fafca61..e581560d75932cbf2a0daf7f70c99570d1ab1c32 100644
--- a/runtime/vm/json_stream.h
+++ b/runtime/vm/json_stream.h
@@ -57,7 +57,7 @@ class JSONStream : ValueObject {
void Setup(Zone* zone,
Dart_Port reply_port,
- const String& seq,
+ const Instance& seq,
const String& method,
const Array& param_keys,
const Array& param_values);
@@ -100,7 +100,6 @@ class JSONStream : ValueObject {
// otherwise.
bool ParamIs(const char* key, const char* value) const;
- const char* seq() const { return seq_; }
const char* method() const { return method_; }
const char** param_keys() const { return param_keys_; }
const char** param_values() const { return param_values_; }
@@ -171,7 +170,7 @@ class JSONStream : ValueObject {
RingServiceIdZone default_id_zone_;
ServiceIdZone* id_zone_;
Dart_Port reply_port_;
- const char* seq_;
+ Instance& seq_;
const char* method_;
const char** param_keys_;
const char** param_values_;
« no previous file with comments | « runtime/bin/vmservice/server.dart ('k') | runtime/vm/json_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698