Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1414)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/service/message.dart

Issue 1255003003: Make VM service id handling JSON-RPC 2 compliant. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Code review changes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/json_stream.cc ('K') | « runtime/vm/service.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service/message.dart
diff --git a/runtime/vm/service/message.dart b/runtime/vm/service/message.dart
index d54cb4c338fa3bdb0fec7fa74deb92845472433f..d99c4bf8690442cc5687a04bfe20d6a14cf9c2e7 100644
--- a/runtime/vm/service/message.dart
+++ b/runtime/vm/service/message.dart
@@ -102,7 +102,7 @@ class Message {
var request = new List(6)
..[0] = 0 // Make room for OOB message type.
..[1] = receivePort.sendPort
- ..[2] = serial.toString()
+ ..[2] = serial
..[3] = method
..[4] = keys
..[5] = values;
@@ -129,7 +129,7 @@ class Message {
var request = new List(6)
..[0] = 0 // Make room for OOB message type.
..[1] = receivePort.sendPort
- ..[2] = serial.toString()
+ ..[2] = serial
..[3] = method
..[4] = keys
..[5] = values;
« runtime/vm/json_stream.cc ('K') | « runtime/vm/service.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698