Make VM service id handling JSON-RPC 2 compliant.

runtime/vm/json_stream.h

Index: runtime/vm/json_stream.h
diff --git a/runtime/vm/json_stream.h b/runtime/vm/json_stream.h
index d314dbf62eae1cafa5bb861be4d802132fafca61..5f604d4f0e1c0d13a535e5b812c984ba46b3352d 100644
--- a/runtime/vm/json_stream.h
+++ b/runtime/vm/json_stream.h
@@ -57,7 +57,7 @@ class JSONStream : ValueObject {
 
   void Setup(Zone* zone,
              Dart_Port reply_port,
-             const String& seq,
+             const Instance& seq,
              const String& method,
              const Array& param_keys,
              const Array& param_values);
@@ -100,7 +100,7 @@ class JSONStream : ValueObject {
   // otherwise.
   bool ParamIs(const char* key, const char* value) const;
 
-  const char* seq() const { return seq_; }
+  Instance& seq() const { return seq_; }

[Cutch, 2015/07/27 21:10:10]

RawInstance* seq() const { return seq_.raw(); }

[nweiz, 2015/07/27 21:17:35]

This causes an "invalid use of incomplete type ‘class dart::Instance’" error. Do
we need to have this method? I don't think any external classes use it.

   const char* method() const { return method_; }
   const char** param_keys() const { return param_keys_; }
   const char** param_values() const { return param_values_; }
@@ -171,7 +171,7 @@ class JSONStream : ValueObject {
   RingServiceIdZone default_id_zone_;
   ServiceIdZone* id_zone_;
   Dart_Port reply_port_;
-  const char* seq_;
+  Instance& seq_;
   const char* method_;
   const char** param_keys_;
   const char** param_values_;