Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm

Issue 12550006: Mac: Add a shortcut to open the Apps page from the bookmark bar. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed failing unit tests. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm
index ec9bf5cdd33916552d608cacc536666ff1c4f9ec..a6c38c94044084b3b846f24b72039b4bae537094 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm
@@ -17,9 +17,9 @@ class BookmarkBarFolderButtonCellTest : public CocoaTest {
TEST_F(BookmarkBarFolderButtonCellTest, Create) {
scoped_nsobject<BookmarkBarFolderButtonCell> cell;
cell.reset([[BookmarkBarFolderButtonCell buttonCellForNode:nil
- menuController:nil
- cellText:nil
- cellImage:nil] retain]);
+ text:nil
+ image:nil
+ menuController:nil] retain]);
EXPECT_TRUE(cell);
}
@@ -41,9 +41,9 @@ TEST_F(BookmarkBarFolderButtonCellTest, FaviconPositioning) {
[[BookmarkButtonCell alloc] initTextCell:@"Testing"]);
scoped_nsobject<BookmarkBarFolderButtonCell> folder_cell(
[[BookmarkBarFolderButtonCell buttonCellForNode:nil
- menuController:nil
- cellText:@"Testing"
- cellImage:image] retain]);
+ text:@"Testing"
Alexei Svitkine (slow) 2013/03/11 21:06:43 Align the :'s.
beaudoin 2013/03/11 21:29:56 Done.
+ image:image
+ menuController:nil] retain]);
ASSERT_TRUE(cell.get());
ASSERT_TRUE(folder_cell.get());

Powered by Google App Engine
This is Rietveld 408576698