Mac: Add a shortcut to open the Apps page from the bookmark bar.

chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.h"
 
+#include "base/prefs/pref_service.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"
+#include "chrome/common/pref_names.h"
 
-BookmarkBarBridge::BookmarkBarBridge(BookmarkBarController* controller,
+
+BookmarkBarBridge::BookmarkBarBridge(Browser* browser,
+                                     BookmarkBarController* controller,
                                      BookmarkModel* model)
     : controller_(controller),
       model_(model),
       batch_mode_(false) {
   model_->AddObserver(this);
 
   // Bookmark loading is async; it may may not have happened yet.
   // We will be notified when that happens with the AddObserver() call.
   if (model->IsLoaded())
     Loaded(model, false);
+
+  profile_pref_registrar_.Init(browser->profile()->GetPrefs());

[Alexei Svitkine (slow), 2013/03/07 21:17:07]

Are you only using |browser| to get a profile? If so, pass in a profile.

[John Grabowski, 2013/03/07 21:35:14]

+1

[beaudoin, 2013/03/08 00:02:50]

Done.

+  profile_pref_registrar_.Add(
+      prefs::kShowAppsShortcutInBookmarkBar,
+      base::Bind(&BookmarkBarBridge::OnAppsPageShortcutVisibilityChanged,
+      base::Unretained(this)));

[Alexei Svitkine (slow), 2013/03/07 21:17:07]

Indent this line 4 more.

[beaudoin, 2013/03/08 00:02:50]

Done.

 }
 
 BookmarkBarBridge::~BookmarkBarBridge() {
   model_->RemoveObserver(this);
 }
 
 void BookmarkBarBridge::Loaded(BookmarkModel* model, bool ids_reassigned) {
   [controller_ loaded:model];
 }
 
@@ skipping 43 matching lines @@
 
 void BookmarkBarBridge::ExtensiveBookmarkChangesBeginning(
     BookmarkModel* model) {
   batch_mode_ = true;
 }
 
 void BookmarkBarBridge::ExtensiveBookmarkChangesEnded(BookmarkModel* model) {
   batch_mode_ = false;
   [controller_ loaded:model];
 }
+
+void BookmarkBarBridge::OnAppsPageShortcutVisibilityChanged() {
+  [controller_ updateAppsPageShortcutButtonVisibility];
+}