Mac: Add a shortcut to open the Apps page from the bookmark bar.

chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h"
 
 #include "base/mac/bundle_locations.h"
 #include "base/mac/mac_util.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
@@ skipping 344 matching lines @@
 }
 
 #pragma mark Private Methods
 
 - (BookmarkButtonCell*)cellForBookmarkNode:(const BookmarkNode*)child {
   NSImage* image = child ? [barController_ faviconForNode:child] : nil;
   BookmarkContextMenuCocoaController* menuController =
       [barController_ menuController];
   BookmarkBarFolderButtonCell* cell =
       [BookmarkBarFolderButtonCell buttonCellForNode:child
-                                      menuController:menuController
-                                            cellText:nil
-                                           cellImage:image];
+                                                text:nil
+                                               image:image
+                                      menuController:menuController];
   [cell setTag:kStandardButtonTypeWithLimitedClickFeedback];
   return cell;
 }
 
 // Redirect to our logic shared with BookmarkBarController.
 - (IBAction)openBookmarkFolderFromButton:(id)sender {
   [folderTarget_ openBookmarkFolderFromButton:sender];
 }
 
 // Create a bookmark button for the given node using frame.
@@ skipping 37 matching lines @@
   DCHECK(button);
 
   [button setCell:cell];
   [button setDelegate:self];
   if (node) {
     if (node->is_folder()) {
       [button setTarget:self];
       [button setAction:@selector(openBookmarkFolderFromButton:)];
     } else {
       // Make the button do something.
       [button setTarget:barController_];

[Alexei Svitkine (slow), 2013/03/11 21:06:43]

That shouldn't be showing up the diff, is your base set correctly?

[beaudoin, 2013/03/11 21:29:56]

Hmmm, it seems ok, and no diff show up here for me. Bug on your side? Or are you
comparing to a previous patchset?

[Alexei Svitkine (slow), 2013/03/11 21:39:54]

Ah, that was it, my bad!

       [button setAction:@selector(openBookmark:)];
       // Add a tooltip.
       [button setToolTip:[BookmarkMenuCocoaController tooltipForNode:node]];
       [button setAcceptsTrackIn:YES];
     }
   } else {
     [button setEnabled:NO];
     [button setBordered:NO];
   }
   return button;
@@ skipping 1529 matching lines @@
 
 - (void)setIgnoreAnimations:(BOOL)ignore {
   ignoreAnimations_ = ignore;
 }
 
 - (BookmarkButton*)buttonThatMouseIsIn {
   return buttonThatMouseIsIn_;
 }
 
 @end  // BookmarkBarFolderController