Mac: Add a shortcut to open the Apps page from the bookmark bar.

chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h"
 
 #include "base/logging.h"
 #include "base/sys_string_conversions.h"
 #import "chrome/browser/bookmarks/bookmark_model.h"
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_button.h"
@@ skipping 25 matching lines @@
               cellImage:(NSImage*)cellImage {
   id buttonCell =
       [[[BookmarkButtonCell alloc] initForNode:node
                                    contextMenu:contextMenu
                                       cellText:cellText
                                      cellImage:cellImage]
        autorelease];
   return buttonCell;
 }
 
++ (id)buttonCellForContextMenu:(NSMenu*)contextMenu
+                      cellText:(NSString*)cellText
+                     cellImage:(NSImage*)cellImage {
+  id buttonCell =
+      [[[BookmarkButtonCell alloc] initForContextMenu:contextMenu
+                                             cellText:cellText
+                                            cellImage:cellImage]
+       autorelease];
+  return buttonCell;
+}
+
 - (id)initForNode:(const BookmarkNode*)node
       contextMenu:(NSMenu*)contextMenu
          cellText:(NSString*)cellText
         cellImage:(NSImage*)cellImage {
   if ((self = [super initTextCell:cellText])) {
     [self configureBookmarkButtonCell];
     [self setTextColor:[NSColor blackColor]];
     [self setBookmarkNode:node];
 
     if (node) {
       NSString* title = base::SysUTF16ToNSString(node->GetTitle());
       [self setBookmarkCellText:title image:cellImage];
       [self setMenu:contextMenu];
     } else {
       [self setEmpty:YES];
       [self setBookmarkCellText:l10n_util::GetNSString(IDS_MENU_EMPTY_SUBMENU)
                           image:nil];
     }
   }
 
   return self;
 }
 
+- (id)initForContextMenu:(NSMenu*)contextMenu
+         cellText:(NSString*)cellText

[Alexei Svitkine (slow), 2013/03/08 19:45:48]

Align the :'s

+        cellImage:(NSImage*)cellImage {
+  if ((self = [super initTextCell:cellText])) {
+    [self configureBookmarkButtonCell];
+    [self setTextColor:[NSColor blackColor]];
+    [self setBookmarkNode:NULL];
+    [self setBookmarkCellText:cellText image:cellImage];
+    [self setMenu:contextMenu];
+    // This is a custom button not attached to any node. It is no considered
+    // empty even if its bookmark node is NULL.
+    [self setEmpty:NO];
+  }
+
+  return self;
+}
+
 - (id)initTextCell:(NSString*)string {
   return [self initForNode:nil contextMenu:nil cellText:string cellImage:nil];
 }
 
 // Used by the off-the-side menu, the only case where a
 // BookmarkButtonCell is loaded from a nib.
 - (void)awakeFromNib {
   [self configureBookmarkButtonCell];
 }
 
@@ skipping 75 matching lines @@
                                             pointerValue]);
 }
 
 // We share the context menu among all bookmark buttons.  To allow us
 // to disambiguate when needed (e.g. "open bookmark"), we set the
 // menu's associated bookmark node ID to be our represented object.
 - (NSMenu*)menu {
   if (empty_)
     return nil;
   BookmarkMenu* menu = (BookmarkMenu*)[super menu];
-  const BookmarkNode* node =
-      static_cast<const BookmarkNode*>([[self representedObject] pointerValue]);
+  const BookmarkNode* node = [self bookmarkNode];
+
+  // If node is NULL, this is a custom button, the menu does not represent
+  // anything.

[Alexei Svitkine (slow), 2013/03/08 19:45:48]

Is this how the Windows implementation works? No context menu for the Apps
button?

+  if (!node)
+    return nil;
 
   if (node->parent() && node->parent()->type() == BookmarkNode::FOLDER) {
     content::RecordAction(UserMetricsAction("BookmarkBarFolder_CtxMenu"));
   } else {
     content::RecordAction(UserMetricsAction("BookmarkBar_CtxMenu"));
   }
 
   [menu setRepresentedObject:[NSNumber numberWithLongLong:node->id()]];
 
   return menu;
@@ skipping 91 matching lines @@
               respectFlipped:YES
                        hints:nil];
   }
 }
 
 - (int)verticalTextOffset {
   return 0;
 }
 
 @end