Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1254973004: Fix FX_BOOL compilation errors under windows (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix FX_BOOL compilation errors under windows - Bool functions should not return -1 for error. - Bool variables should not be assigned 2 - Bool / int32_t prototypes should match. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a25b4bca69ab26d174edb8cefbdcfc1a0353915a

Patch Set 1 #

Patch Set 2 : Fix a few more found on win side' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -23 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 1 chunk +5 lines, -10 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdftext/text_int.h View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_IconList.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Tom Sepez
Lei, from failed run at http://build.chromium.org/p/client.pdfium/builders/win/builds/253/steps/compile%20with%20ninja/logs/stdio
5 years, 4 months ago (2015-07-27 19:27:05 UTC) #1
Lei Zhang
lgtm
5 years, 4 months ago (2015-07-27 20:16:53 UTC) #2
Tom Sepez
Found a few more, please re-review.
5 years, 4 months ago (2015-07-27 20:37:28 UTC) #3
Tom Sepez
Found a few more, please re-review.
5 years, 4 months ago (2015-07-27 20:37:35 UTC) #4
Lei Zhang
lgtm++
5 years, 4 months ago (2015-07-27 20:56:57 UTC) #5
Tom Sepez
5 years, 4 months ago (2015-07-27 21:38:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a25b4bca69ab26d174edb8cefbdcfc1a0353915a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698