Fix generated file dependencies for upcoming gn

Fix generated file dependencies for upcoming gn

BUG=
R=brettw@chromium.org, jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/677be22e6e22bddecdbd1c1e5ac24dc0818c241f

[cdotstout, 2015-07-31 17:28:12]

cstout@chromium.org changed reviewers:
+ brettw@chromium.org, jamesr@chromium.org

[brettw, 2015-07-31 17:32:26]

LGTM, although wait for a mojo reviewer before submitting (I don't understand
the project enough to make non-mechanical decisions.

https://codereview.chromium.org/1254963012/diff/1/mojo/public/dart/rules.gni
File mojo/public/dart/rules.gni (right):

https://codereview.chromium.org/1254963012/diff/1/mojo/public/dart/rules.gni#...
mojo/public/dart/rules.gni:130: deps = []
You can remove this line and in the condition below change += to =

https://codereview.chromium.org/1254963012/diff/1/third_party/cython/rules.gni
File third_party/cython/rules.gni (right):

https://codereview.chromium.org/1254963012/diff/1/third_party/cython/rules.gn...
third_party/cython/rules.gni:37: deps = []
You can delete both of these lines and convert += to = below.

[cdotstout, 2015-07-31 17:37:15]

https://codereview.chromium.org/1254963012/diff/1/mojo/public/dart/rules.gni
File mojo/public/dart/rules.gni (right):

https://codereview.chromium.org/1254963012/diff/1/mojo/public/dart/rules.gni#...
mojo/public/dart/rules.gni:130: deps = []
On 2015/07/31 17:32:26, brettw wrote:
> You can remove this line and in the condition below change += to =

Done.

https://codereview.chromium.org/1254963012/diff/1/third_party/cython/rules.gni
File third_party/cython/rules.gni (right):

https://codereview.chromium.org/1254963012/diff/1/third_party/cython/rules.gn...
third_party/cython/rules.gni:37: deps = []
On 2015/07/31 17:32:26, brettw wrote:
> You can delete both of these lines and convert += to = below.

Done.

[jamesr, 2015-08-03 17:48:49]

https://codereview.chromium.org/1254963012/diff/20001/mojo/nacl/BUILD.gn
File mojo/nacl/BUILD.gn (left):

https://codereview.chromium.org/1254963012/diff/20001/mojo/nacl/BUILD.gn#oldc...
mojo/nacl/BUILD.gn:58: "//shell:apptests",
are the shell apptests built for nacl via another path now? i see
mojo:shell_apptests_x64.nexe in the nacl_apptests config file

[cdotstout, 2015-08-03 18:14:58]

https://codereview.chromium.org/1254963012/diff/20001/mojo/nacl/BUILD.gn
File mojo/nacl/BUILD.gn (left):

https://codereview.chromium.org/1254963012/diff/20001/mojo/nacl/BUILD.gn#oldc...
mojo/nacl/BUILD.gn:58: "//shell:apptests",
On 2015/08/03 17:48:49, jamesr wrote:
> are the shell apptests built for nacl via another path now? i see
> mojo:shell_apptests_x64.nexe in the nacl_apptests config file

I don't think it is.

When apptests is built for nacl, should it embed pingable_app built with nacl or
with the default toolchain?

[jamesr, 2015-08-03 18:32:21]

On 2015/08/03 at 18:14:58, cstout wrote:
> https://codereview.chromium.org/1254963012/diff/20001/mojo/nacl/BUILD.gn
> File mojo/nacl/BUILD.gn (left):
> 
>
https://codereview.chromium.org/1254963012/diff/20001/mojo/nacl/BUILD.gn#oldc...
> mojo/nacl/BUILD.gn:58: "//shell:apptests",
> On 2015/08/03 17:48:49, jamesr wrote:
> > are the shell apptests built for nacl via another path now? i see
> > mojo:shell_apptests_x64.nexe in the nacl_apptests config file
> 
> I don't think it is.
> 
> When apptests is built for nacl, should it embed pingable_app built with nacl
or with the default toolchain?

I think the nacl_apptests is testing mojo:shell_apptests_x64.nexe dynamically
loading pingable_app build with the default toolchain.

[jamesr, 2015-08-04 00:49:23]

I think it'd be OK to disable the nacl shell_apptests target temporarily while
we try to figure it out.  Please also comment the shell_apptests section out of
//mojo/tools/data/nacl_apptests as well or it will continue to run using a stale
build (until someone does a clean build, at which point it'll fail).

[jamesr, 2015-08-04 22:13:26]

lgtm

[cdotstout, 2015-08-04 22:14:49]

On 2015/08/04 00:49:23, jamesr wrote:
> I think it'd be OK to disable the nacl shell_apptests target temporarily while
> we try to figure it out.  Please also comment the shell_apptests section out
of
> //mojo/tools/data/nacl_apptests as well or it will continue to run using a
stale
> build (until someone does a clean build, at which point it'll fail).

Working with Brett's suggested workaround

[cdotstout, 2015-08-04 22:15:26]

Committed patchset #3 (id:40001) manually as
677be22e6e22bddecdbd1c1e5ac24dc0818c241f (presubmit successful).