[Views] Move modality tests from widget_unittest.cc to desktop_native_widget_aura_unittest.cc.

[Views] Move modality tests from widget_unittest.cc to desktop_native_widget_aura_unittest.cc.

These tests were both under USE_AURA when they were originally
added (r226609 and r227041):
WindowMouseModalityTest
WindowModalityActivationTest

Later, Aura became implied with Views (r255976).

With MacViews, we could if-def these out again, but since they're
also if-def'd out on OS_CHROMEOS, move them to
desktop_native_widget_aura_unittest.cc.

This also moves TestDesktopWidgetDelegate to widget_test.h and
EventCountView to test_views.h.

BUG=378134
Committed: https://crrev.com/480a2ab448e9a1972a6f1bee9746946a375fb797
Cr-Commit-Position: refs/heads/master@{#341638}

[jackhou1, 2015-08-03 00:06:34]

jackhou@chromium.org changed reviewers:
+ tapted@chromium.org

[jackhou1, 2015-08-03 00:06:34]

tapted, PTAL

[tapted, 2015-08-03 01:10:46]

lgtm TestDesktopWidgetDelegate should maybe be in its own file, but maybe
there's a plus in "advertising" it in widget_test.h to avoid more boilerplate.

https://codereview.chromium.org/1254963010/diff/40001/ui/views/test/widget_te...
File ui/views/test/widget_test.cc (right):

https://codereview.chromium.org/1254963010/diff/40001/ui/views/test/widget_te...
ui/views/test/widget_test.cc:123: // Initialize the Widget, adding some
meaningful default InitParams.
remove

https://codereview.chromium.org/1254963010/diff/40001/ui/views/test/widget_te...
ui/views/test/widget_test.cc:133: // WidgetDelegate s:
remove

https://codereview.chromium.org/1254963010/diff/40001/ui/views/widget/widget_...
File ui/views/widget/widget_unittest.cc (right):

https://codereview.chromium.org/1254963010/diff/40001/ui/views/widget/widget_...
ui/views/widget/widget_unittest.cc:2951: #if !defined(OS_CHROMEOS)
odd... this is already in #if !defined(OS_CHROMEOS) - not sure if that's
intentional. Did you try just removing the #if that starts on line 2933?

[jackhou1, 2015-08-03 05:09:50]

https://codereview.chromium.org/1254963010/diff/40001/ui/views/test/widget_te...
File ui/views/test/widget_test.cc (right):

https://codereview.chromium.org/1254963010/diff/40001/ui/views/test/widget_te...
ui/views/test/widget_test.cc:123: // Initialize the Widget, adding some
meaningful default InitParams.
On 2015/08/03 01:10:46, tapted wrote:
> remove

Done.

https://codereview.chromium.org/1254963010/diff/40001/ui/views/test/widget_te...
ui/views/test/widget_test.cc:133: // WidgetDelegate s:
On 2015/08/03 01:10:46, tapted wrote:
> remove

Done.

https://codereview.chromium.org/1254963010/diff/40001/ui/views/widget/widget_...
File ui/views/widget/widget_unittest.cc (right):

https://codereview.chromium.org/1254963010/diff/40001/ui/views/widget/widget_...
ui/views/widget/widget_unittest.cc:2951: #if !defined(OS_CHROMEOS)
On 2015/08/03 01:10:46, tapted wrote:
> odd... this is already in #if !defined(OS_CHROMEOS) - not sure if that's
> intentional. Did you try just removing the #if that starts on line 2933?

Done.

[jackhou1, 2015-08-03 07:06:53]

jackhou@chromium.org changed reviewers:
+ sky@chromium.org

[jackhou1, 2015-08-03 07:06:53]

sky, please review for OWNERS

[sky, 2015-08-03 14:50:42]

LGTM

[jackhou1, 2015-08-03 23:11:13]

The CQ bit was checked by jackhou@chromium.org

[jackhou1, 2015-08-03 23:11:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/1254963010/#ps60001
(title: "Address comments.")

[commit-bot: I haz the power, 2015-08-03 23:11:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1254963010/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1254963010/60001

[commit-bot: I haz the power, 2015-08-03 23:18:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-03 23:18:53]

Patchset 4 (id:??) landed as
https://crrev.com/480a2ab448e9a1972a6f1bee9746946a375fb797
Cr-Commit-Position: refs/heads/master@{#341638}