Support XCode's "Right to Left Pseudolanguage" on iOS.

Support XCode's "Right to Left Pseudolanguage" on iOS.

XCode can run apps with a "Right to Left Pseudolanguage" application
language setting, which sets the AppleTextDirection user defaults
key. iOS will treat whatever the current language is as a RTL language
if this key is set. This CL adds a test for this key in
GetTextDirectionForLocale() so that g_icu_text_direction will agree
with iOS about what the current text direction is.

BUG=514625
Committed: https://crrev.com/f51b003d2c2fe471c12ff992a9005c083565a177
Cr-Commit-Position: refs/heads/master@{#342590}

[marq (ping after 24h), 2015-07-24 15:58:25]

marq@chromium.org changed reviewers:
+ droger@chromium.org

[marq (ping after 24h), 2015-07-28 14:30:13]

marq@chromium.org changed reviewers:
+ stuartmorgan@chromium.org, thakis@chromium.org
- droger@chromium.org

[marq (ping after 24h), 2015-07-30 16:57:49]

marq@chromium.org changed reviewers:
+ rohitaro@chromium.org
- stuartmorgan@chromium.org

[marq (ping after 24h), 2015-07-30 16:57:50]

Back to Rohit since he's not OOO anymore.

[marq (ping after 24h), 2015-08-04 12:47:03]

On 2015/07/30 16:57:50, marq wrote:
> Back to Rohit since he's not OOO anymore.

Ping? Anyone?

[rohitrao (ping after 24h), 2015-08-07 16:29:04]

rohitrao@chromium.org changed reviewers:
+ rohitrao@chromium.org
- rohitaro@chromium.org

[rohitrao (ping after 24h), 2015-08-07 16:29:05]

-rohitaro +rohitrao =)

[rohitrao (ping after 24h), 2015-08-07 16:30:08]

ios_util changes LGTM

[marq (ping after 24h), 2015-08-07 16:37:20]

marq@chromium.org changed reviewers:
+ jshin@chromium.org
- thakis@chromium.org

[marq (ping after 24h), 2015-08-07 16:37:20]

+jshin for i18n OWNER

[jungshik at Google, 2015-08-07 17:32:22]

LGTM

https://codereview.chromium.org/1254933002/diff/1/base/i18n/rtl.cc
File base/i18n/rtl.cc (right):

https://codereview.chromium.org/1254933002/diff/1/base/i18n/rtl.cc#newcode140
base/i18n/rtl.cc:140: if (ios::IsForcingRTL())
nit: How about IsInForcedRTL ?

[marq (ping after 24h), 2015-08-10 07:28:37]

Thanks for the review!

https://codereview.chromium.org/1254933002/diff/1/base/i18n/rtl.cc
File base/i18n/rtl.cc (right):

https://codereview.chromium.org/1254933002/diff/1/base/i18n/rtl.cc#newcode140
base/i18n/rtl.cc:140: if (ios::IsForcingRTL())
On 2015/08/07 17:32:22, jungshik at google wrote:
> nit: How about IsInForcedRTL ? 

Done.

[marq (ping after 24h), 2015-08-10 07:28:40]

The CQ bit was checked by marq@chromium.org

[marq (ping after 24h), 2015-08-10 07:28:41]

The patchset sent to the CQ was uploaded after l-g-t-m from jshin@chromium.org,
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/1254933002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-08-10 07:28:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1254933002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1254933002/20001

[commit-bot: I haz the power, 2015-08-10 08:55:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-10 08:56:08]

Patchset 2 (id:??) landed as
https://crrev.com/f51b003d2c2fe471c12ff992a9005c083565a177
Cr-Commit-Position: refs/heads/master@{#342590}