Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1254903002: Make allocation count in TextBatch implicit (Closed)

Created:
5 years, 5 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@4
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make allocation count in TextBatch implicit Committed: https://skia.googlesource.com/skia/+/d602f4d1f7deb9c4b7123a9bc374c8ff784cd548

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : move kMin above first use #

Patch Set 4 : attempt to fix linker bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -31 lines) Patch
M src/gpu/GrAtlasTextContext.cpp View 1 2 3 8 chunks +21 lines, -31 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
bsalomon
5 years, 5 months ago (2015-07-24 15:26:24 UTC) #2
joshualitt
On 2015/07/24 15:26:24, bsalomon wrote: lgtm
5 years, 5 months ago (2015-07-24 15:39:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254903002/20001
5 years, 5 months ago (2015-07-24 15:41:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/2232)
5 years, 5 months ago (2015-07-24 15:43:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254903002/40001
5 years, 5 months ago (2015-07-24 17:06:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/2235)
5 years, 5 months ago (2015-07-24 17:08:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254903002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254903002/60001
5 years, 4 months ago (2015-07-27 12:43:59 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 13:12:03 UTC) #16
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d602f4d1f7deb9c4b7123a9bc374c8ff784cd548

Powered by Google App Engine
This is Rietveld 408576698