Issue 12549003: Merge 144323

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12549003: Merge 144323 (Closed)

Created:
7 years, 9 months ago by dgrogan

Modified:
7 years, 9 months ago

Reviewers:
dgrogan

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/

Visibility:
Public.

More Reviews

Description

Merge 144323 > IndexedDB: IO error when checking schema should destroy LevelDB directory > https://bugs.webkit.org/show_bug.cgi?id=110675 > > Reviewed by Adam Barth. > > Source/WebCore: > > Also some refactoring to remove IDBBackingStore's dependence on > static LevelDBDatabase methods. This facilitated the unit test. > > New unit test - IDBIOErrorTest.CleanUpTest > > * Modules/indexeddb/IDBBackingStore.cpp: > (DefaultLevelDBFactory): > Wraps the previous behavior. > (WebCore::IDBBackingStore::open): > The default parameter provides the previous behavior, which is what > non-tests want. > * Modules/indexeddb/IDBBackingStore.h: > * platform/leveldb/LevelDBDatabase.h: > > Source/WebKit/chromium: > > * WebKit.gyp: > This was cargo-culted. The component build wouldn't run otherwise. > > * WebKit.gypi: > * tests/IDBCleanupOnIOErrorTest.cpp: Added. > TBR=dgrogan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144947

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -8 lines)			Patch
M	Source/WebCore/Modules/indexeddb/IDBBackingStore.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp	View	5 chunks	+24 lines, -6 lines	0 comments	Download
M	Source/WebCore/platform/leveldb/LevelDBDatabase.h	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	Source/WebKit/chromium/WebKit.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/WebKit/chromium/WebKit.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	Source/WebKit/chromium/tests/IDBCleanupOnIOErrorTest.cpp	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r144947.

Expand Messages | Collapse Messages