Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 1254873002: [interpreter] A couple of minor tweaks to BytecodeArray. (Closed)

Created:
5 years, 5 months ago by rmcilroy
Modified:
5 years, 5 months ago
Reviewers:
oth, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] A couple of minor tweaks to BytecodeArray. - Ensure frame_size is always set during allocation. - Add DCHECKs that frame_size is a valid value - Remove locals_count, which we don't need yet (possibly every) - Add a newline at the end of BytecodeArray::Dissassemble for each bytecode. BUG=v8:4280 LOG=N Committed: https://crrev.com/9bb7b980de978dfc76456ef22adc9dd45e734988 Cr-Commit-Position: refs/heads/master@{#29852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -23 lines) Patch
M src/factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/heap.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +11 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
rmcilroy
Orion: could you please take a look. Ulan: could you please RS for OWNERS (any ...
5 years, 5 months ago (2015-07-24 14:04:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254873002/1
5 years, 5 months ago (2015-07-24 14:04:16 UTC) #4
ulan
lgtm
5 years, 5 months ago (2015-07-24 14:12:44 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-24 14:29:39 UTC) #7
oth
On 2015/07/24 14:04:00, rmcilroy wrote: > Orion: could you please take a look. > > ...
5 years, 5 months ago (2015-07-24 14:38:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254873002/1
5 years, 5 months ago (2015-07-24 14:55:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 14:56:31 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 14:56:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bb7b980de978dfc76456ef22adc9dd45e734988
Cr-Commit-Position: refs/heads/master@{#29852}

Powered by Google App Engine
This is Rietveld 408576698