Added GrGLBlend.h|cpp with helper function AppendPorterDuffBlend() in preparation for SkComposeShad…

Added GrGLBlend.h|cpp with helper function AppendPorterDuffBlend() in preparation for SkComposeShader gpu backend

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/cef14bf9ce626e6e6582f3aac18c8e176b987f3e

[wangyix, 2015-07-24 17:47:37]

wangyix@google.com changed reviewers:
+ joshualitt@google.com

[joshualitt, 2015-07-24 18:03:20]

joshualitt@google.com changed reviewers:
+ egdaniel@google.com

[joshualitt, 2015-07-24 18:03:21]

just a nit, looks fine to me.  Adding Greg

https://codereview.chromium.org/1254833003/diff/20001/src/gpu/gl/GrGLBlend.cpp
File src/gpu/gl/GrGLBlend.cpp (right):

https://codereview.chromium.org/1254833003/diff/20001/src/gpu/gl/GrGLBlend.cp...
src/gpu/gl/GrGLBlend.cpp:55: const char* dstColor, const char* outColor,
SkXfermode::Mode mode) {
lets line these up like append_porterduff_term

[wangyix, 2015-07-24 18:13:53]

https://codereview.chromium.org/1254833003/diff/20001/src/gpu/gl/GrGLBlend.cpp
File src/gpu/gl/GrGLBlend.cpp (right):

https://codereview.chromium.org/1254833003/diff/20001/src/gpu/gl/GrGLBlend.cp...
src/gpu/gl/GrGLBlend.cpp:55: const char* dstColor, const char* outColor,
SkXfermode::Mode mode) {
On 2015/07/24 18:03:21, joshualitt wrote:
> lets line these up like append_porterduff_term

Done.

[egdaniel, 2015-07-24 18:14:30]

https://codereview.chromium.org/1254833003/diff/20001/src/gpu/effects/GrPorte...
File src/gpu/effects/GrPorterDuffXferProcessor.cpp (right):

https://codereview.chromium.org/1254833003/diff/20001/src/gpu/effects/GrPorte...
src/gpu/effects/GrPorterDuffXferProcessor.cpp:19: #include "gl/GrGLBlend.h"
move this to above gl/GrGLXferProcessor.h

https://codereview.chromium.org/1254833003/diff/20001/src/gpu/gl/GrGLBlend.h
File src/gpu/gl/GrGLBlend.h (right):

https://codereview.chromium.org/1254833003/diff/20001/src/gpu/gl/GrGLBlend.h#...
src/gpu/gl/GrGLBlend.h:16: void AppendPorterDuffBlend(GrGLFragmentBuilder*
fsBuilder, const char* srcColor,
Add a comment on this function to describe what it does.

[wangyix, 2015-07-24 20:18:15]

https://codereview.chromium.org/1254833003/diff/20001/src/gpu/effects/GrPorte...
File src/gpu/effects/GrPorterDuffXferProcessor.cpp (right):

https://codereview.chromium.org/1254833003/diff/20001/src/gpu/effects/GrPorte...
src/gpu/effects/GrPorterDuffXferProcessor.cpp:19: #include "gl/GrGLBlend.h"
On 2015/07/24 18:14:29, egdaniel wrote:
> move this to above gl/GrGLXferProcessor.h

Done.

https://codereview.chromium.org/1254833003/diff/20001/src/gpu/gl/GrGLBlend.h
File src/gpu/gl/GrGLBlend.h (right):

https://codereview.chromium.org/1254833003/diff/20001/src/gpu/gl/GrGLBlend.h#...
src/gpu/gl/GrGLBlend.h:16: void AppendPorterDuffBlend(GrGLFragmentBuilder*
fsBuilder, const char* srcColor,
On 2015/07/24 18:14:30, egdaniel wrote:
> Add a comment on this function to describe what it does.

Done.

[egdaniel, 2015-07-24 20:21:42]

https://codereview.chromium.org/1254833003/diff/60001/src/gpu/gl/GrGLBlend.cpp
File src/gpu/gl/GrGLBlend.cpp (right):

https://codereview.chromium.org/1254833003/diff/60001/src/gpu/gl/GrGLBlend.cp...
src/gpu/gl/GrGLBlend.cpp:55: const char* dstColor, const char* outColor,
SkXfermode::Mode mode) {
I josh want you to align the parameters here. The skia style is when you use a
second line on parameters they align after the '(' (aka the next line starts
under the first G in GrGLFramgementBuilder.

https://codereview.chromium.org/1254833003/diff/60001/src/gpu/gl/GrGLBlend.cp...
src/gpu/gl/GrGLBlend.cpp:63: srcColor, srcColor,
These actually looked nicer your original way imo. Or some may suggest a single
parameter per line.

[wangyix, 2015-07-24 20:37:16]

https://codereview.chromium.org/1254833003/diff/60001/src/gpu/gl/GrGLBlend.cpp
File src/gpu/gl/GrGLBlend.cpp (right):

https://codereview.chromium.org/1254833003/diff/60001/src/gpu/gl/GrGLBlend.cp...
src/gpu/gl/GrGLBlend.cpp:55: const char* dstColor, const char* outColor,
SkXfermode::Mode mode) {
On 2015/07/24 20:21:42, egdaniel wrote:
> I josh want you to align the parameters here. The skia style is when you use a
> second line on parameters they align after the '(' (aka the next line starts
> under the first G in GrGLFramgementBuilder.

Done.

https://codereview.chromium.org/1254833003/diff/60001/src/gpu/gl/GrGLBlend.cp...
src/gpu/gl/GrGLBlend.cpp:63: srcColor, srcColor,
On 2015/07/24 20:21:42, egdaniel wrote:
> These actually looked nicer your original way imo. Or some may suggest a
single
> parameter per line.

Done.

[egdaniel, 2015-07-24 20:39:00]

lgtm

[wangyix, 2015-07-24 20:41:00]

The CQ bit was checked by wangyix@google.com

[commit-bot: I haz the power, 2015-07-24 20:41:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1254833003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1254833003/80001

[commit-bot: I haz the power, 2015-07-24 20:48:29]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/cef14bf9ce626e6e6582f3aac18c8e176b987f3e