Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1254823005: Facilitate use of `bugpoint` on `-pnacl-sjlj-eh` by adding a hidden option to ignore undefined EH s… (Closed)

Created:
5 years, 4 months ago by Richard Diamond
Modified:
5 years, 4 months ago
Reviewers:
JF
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Facilitate use of `bugpoint` on `-pnacl-sjlj-eh` by adding a hidden option to ignore undefined EH symbols. R=jfb@chromium.org BUG= Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/f4f7fe4ff7f35543ba3ad9e63213bab8842ce443

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M lib/Transforms/NaCl/PNaClSjLjEH.cpp View 1 3 chunks +32 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Richard Diamond
5 years, 4 months ago (2015-07-31 11:22:24 UTC) #1
JF
lgtm
5 years, 4 months ago (2015-07-31 15:39:59 UTC) #2
JF
5 years, 4 months ago (2015-07-31 15:48:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f4f7fe4ff7f35543ba3ad9e63213bab8842ce443 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698