Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1254723005: Revert of Revert "In RegExp, lastIndex is read with ToLength, not ToInteger" (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert "In RegExp, lastIndex is read with ToLength, not ToInteger" (patchset #1 id:1 of https://codereview.chromium.org/1243053005/) Reason for revert: [Sheriff] This causes a breakage with custom snapshot (bisected locally): http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/1190 Original issue's description: > Revert "In RegExp, lastIndex is read with ToLength, not ToInteger" > > $toLength is slow, causing a 3.8%-8% regression in the Octane RegExp > benchmark. Reverting this patch brings it back up. To make this change, > we'll need a faster implementation fo $toLength. > > BUG=chromium:513160 > LOG=Y > R=adamk > > Committed: https://crrev.com/477d651c6a978bdf34954048a235895c62dab0ac > Cr-Commit-Position: refs/heads/master@{#29830} TBR=adamk@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:513160 Committed: https://crrev.com/7d02830e7436d23cb00e1d39ea0347fb1be2265d Cr-Commit-Position: refs/heads/master@{#29835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M src/regexp.js View 2 chunks +6 lines, -6 lines 0 comments Download
M test/mozilla/mozilla.status View 1 chunk +2 lines, -0 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/test262/test262.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Michael Achenbach
Created Revert of Revert "In RegExp, lastIndex is read with ToLength, not ToInteger"
5 years, 5 months ago (2015-07-24 08:25:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254723005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254723005/1
5 years, 5 months ago (2015-07-24 08:25:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 08:26:05 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7d02830e7436d23cb00e1d39ea0347fb1be2265d Cr-Commit-Position: refs/heads/master@{#29835}
5 years, 5 months ago (2015-07-24 08:26:20 UTC) #4
Michael Achenbach
Repro instructions: git checkout 477d651 gclient sync --nohooks GYP_GENERATORS=ninja GYP_DEFINES="target_arch=x64 v8_target_arch=x64 use_goma=1 embed_script=/path/to/v8/test/mjsunit/mjsunit.js v8_enable_slow_dchecks=1 v8_optimized_debug=1" ...
5 years, 5 months ago (2015-07-24 08:37:14 UTC) #5
Dan Ehrenberg
Are you sure you chose this patch correctly? When I run the failing test locally, ...
5 years, 5 months ago (2015-07-24 18:17:00 UTC) #6
Dan Ehrenberg
5 years, 5 months ago (2015-07-24 18:49:03 UTC) #7
Message was sent while issue was closed.
On 2015/07/24 18:17:00, Dan Ehrenberg wrote:
> Are you sure you chose this patch correctly? When I run the failing test
> locally, including the patch that you reverted, it passes.

Oh, sorry, following those precise instructions that Yang mailed, I can
reproduce the error. And the rollback fixes it.

Powered by Google App Engine
This is Rietveld 408576698