Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par…

Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into parent script context".

This reverts commit 362b378501ac2220655e16f49c6d1aa734e657f4.

R=ishell@chromium.org

Committed: https://crrev.com/440ae014e56924b52337c3747221b79283f07b81
Cr-Commit-Position: refs/heads/master@{#29849}

[Benedikt Meurer, 2015-07-24 07:59:53]

Hey Igor,

Let's turn on the flag again. :-)
Please take a look.

Thanks,
Benedikt

[Igor Sheludko, 2015-07-24 08:09:38]

lgtm

[Benedikt Meurer, 2015-07-24 08:45:20]

bmeurer@chromium.org changed reviewers:
+ plind44@gmail.com, v8-mips-ports@googlegroups.com

[Benedikt Meurer, 2015-07-24 08:45:21]

Hey MIPS people,

Can you look into the failures? As far as I can tell, we need at least

diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc
index 272feda..352289a 100644
--- a/src/mips/code-stubs-mips.cc
+++ b/src/mips/code-stubs-mips.cc
@@ -5298,8 +5298,7 @@ void LoadGlobalViaContextStub::Generate(MacroAssembler*
masm) {
   // Fallback to the runtime.
   __ bind(&slow_case);
   __ SmiTag(slot_reg);
-  __ Drop(1);  // Pop return address.
-  __ Push(slot_reg, name_reg, result_reg);
+  __ Push(slot_reg, name_reg);
   __ TailCallRuntime(Runtime::kLoadGlobalViaContext, 2, 1);
 }

@@ -5410,8 +5409,7 @@ void StoreGlobalViaContextStub::Generate(MacroAssembler*
masm) {
   // Fallback to the runtime.
   __ bind(&slow_case);
   __ SmiTag(slot_reg);
-  __ Drop(1);  // Pop return address.
-  __ Push(slot_reg, name_reg, value_reg, cell_reg);
+  __ Push(slot_reg, name_reg, value_reg);
   __ TailCallRuntime(is_strict(language_mode())
                          ? Runtime::kStoreGlobalViaContext_Strict
                          : Runtime::kStoreGlobalViaContext_Sloppy,

but then there are still failures left, which I'm not sure about.

Please take a look.

Thanks,
Benedikt

[Igor Sheludko, 2015-07-24 11:10:29]

On 2015/07/24 08:45:21, Benedikt Meurer wrote:
> Hey MIPS people,
> 
> Can you look into the failures? As far as I can tell, we need at least
> 
> diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc
> index 272feda..352289a 100644
> --- a/src/mips/code-stubs-mips.cc
> +++ b/src/mips/code-stubs-mips.cc
> @@ -5298,8 +5298,7 @@ void LoadGlobalViaContextStub::Generate(MacroAssembler*
> masm) {
>    // Fallback to the runtime.
>    __ bind(&slow_case);
>    __ SmiTag(slot_reg);
> -  __ Drop(1);  // Pop return address.
> -  __ Push(slot_reg, name_reg, result_reg);
> +  __ Push(slot_reg, name_reg);
>    __ TailCallRuntime(Runtime::kLoadGlobalViaContext, 2, 1);
>  }
> 
> @@ -5410,8 +5409,7 @@ void StoreGlobalViaContextStub::Generate(MacroAssembler*
> masm) {
>    // Fallback to the runtime.
>    __ bind(&slow_case);
>    __ SmiTag(slot_reg);
> -  __ Drop(1);  // Pop return address.
> -  __ Push(slot_reg, name_reg, value_reg, cell_reg);
> +  __ Push(slot_reg, name_reg, value_reg);
>    __ TailCallRuntime(is_strict(language_mode())
>                           ? Runtime::kStoreGlobalViaContext_Strict
>                           : Runtime::kStoreGlobalViaContext_Sloppy,
> 
> but then there are still failures left, which I'm not sure about.
> 
> Please take a look.
> 
> Thanks,
> Benedikt

Added comments about MIPS ports here:
https://codereview.chromium.org/1238143002/

[Igor Sheludko, 2015-07-24 14:20:13]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2015-07-24 14:20:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1254723004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1254723004/1

[commit-bot: I haz the power, 2015-07-24 14:23:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-24 14:23:23]

Patchset 1 (id:??) landed as
https://crrev.com/440ae014e56924b52337c3747221b79283f07b81
Cr-Commit-Position: refs/heads/master@{#29849}

[Jakob Kummerow, 2015-07-29 09:26:49]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1260423002/ by jkummerow@chromium.org.

The reason for reverting is: Suspected to cause Canary crashes.