core/src/fxcrt/fx_basic_bstring.cpp - Issue 1254703002: FX_BOOL considered harmful, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_basic_bstring.cpp

Issue 1254703002: FX_BOOL considered harmful, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcrt/fx_basic_bstring.cpp

diff --git a/core/src/fxcrt/fx_basic_bstring.cpp b/core/src/fxcrt/fx_basic_bstring.cpp

index 5eeb33b0496bdd803110340a7057a0c25e986cdb..47c1c5b6b205248411b2f3cbbf36c83a2927a70c 100644

--- a/core/src/fxcrt/fx_basic_bstring.cpp

+++ b/core/src/fxcrt/fx_basic_bstring.cpp

@@ -1086,9 +1086,9 @@ FX_STRSIZE FX_ftoa(FX_FLOAT d, FX_CHAR* buf)

if (d == 0.0f) {

return 1;

}

- FX_BOOL bNegative = FALSE;

+ bool bNegative = false;

if (d < 0) {

- bNegative = TRUE;

+ bNegative = true;

d = -d;

}

int scale = 1;

« no previous file with comments | « core/src/fxcrt/fx_basic_array.cpp ('k') | core/src/fxcrt/fx_basic_buffer.cpp » ('j') | no next file with comments »