Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: fpdfsdk/src/pdfwindow/PWL_Button.cpp

Issue 1254703002: FX_BOOL considered harmful, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/jsapi/fxjs_v8.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_Caret.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../include/pdfwindow/PDFWindow.h" 7 #include "../../include/pdfwindow/PDFWindow.h"
8 #include "../../include/pdfwindow/PWL_Wnd.h" 8 #include "../../include/pdfwindow/PWL_Wnd.h"
9 #include "../../include/pdfwindow/PWL_Button.h" 9 #include "../../include/pdfwindow/PWL_Button.h"
10 #include "../../include/pdfwindow/PWL_Utils.h" 10 #include "../../include/pdfwindow/PWL_Utils.h"
11 11
12 /* ------------------------------- CPWL_Button --------------------------------- - */ 12 /* ------------------------------- CPWL_Button --------------------------------- - */
13 13
14 CPWL_Button::CPWL_Button() : 14 CPWL_Button::CPWL_Button() :
15 » m_bMouseDown(FALSE) 15 » m_bMouseDown(false)
16 { 16 {
17 } 17 }
18 18
19 CPWL_Button::~CPWL_Button() 19 CPWL_Button::~CPWL_Button()
20 { 20 {
21 // PWL_TRACE("~CPWL_Button\n"); 21 // PWL_TRACE("~CPWL_Button\n");
22 } 22 }
23 23
24 CFX_ByteString CPWL_Button::GetClassName() const 24 CFX_ByteString CPWL_Button::GetClassName() const
25 { 25 {
26 return "CPWL_Button"; 26 return "CPWL_Button";
27 } 27 }
28 28
29 void CPWL_Button::OnCreate(PWL_CREATEPARAM & cp) 29 void CPWL_Button::OnCreate(PWL_CREATEPARAM & cp)
30 { 30 {
31 cp.eCursorType = FXCT_HAND; 31 cp.eCursorType = FXCT_HAND;
32 } 32 }
33 33
34 FX_BOOL CPWL_Button::OnLButtonDown(const CPDF_Point & point, FX_DWORD nFlag) 34 bool CPWL_Button::OnLButtonDown(const CPDF_Point & point, FX_DWORD nFlag)
35 { 35 {
36 CPWL_Wnd::OnLButtonDown(point, nFlag); 36 CPWL_Wnd::OnLButtonDown(point, nFlag);
37 37
38 » m_bMouseDown = TRUE; 38 » m_bMouseDown = true;
39 SetCapture(); 39 SetCapture();
40 40
41 » return TRUE; 41 » return true;
42 } 42 }
43 43
44 FX_BOOL CPWL_Button::OnLButtonUp(const CPDF_Point & point, FX_DWORD nFlag) 44 bool CPWL_Button::OnLButtonUp(const CPDF_Point & point, FX_DWORD nFlag)
45 { 45 {
46 CPWL_Wnd::OnLButtonUp(point, nFlag); 46 CPWL_Wnd::OnLButtonUp(point, nFlag);
47 47
48 ReleaseCapture(); 48 ReleaseCapture();
49 » m_bMouseDown = FALSE; 49 » m_bMouseDown = false;
50 50
51 » return TRUE; 51 » return true;
52 } 52 }
53 53
OLDNEW
« no previous file with comments | « fpdfsdk/src/jsapi/fxjs_v8.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_Caret.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698