Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Side by Side Diff: fpdfsdk/src/javascript/console.cpp

Issue 1254703002: FX_BOOL considered harmful, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/javascript/color.cpp ('k') | fpdfsdk/src/javascript/event.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../include/javascript/JavaScript.h" 7 #include "../../include/javascript/JavaScript.h"
8 #include "../../include/javascript/IJavaScript.h" 8 #include "../../include/javascript/IJavaScript.h"
9 #include "../../include/javascript/JS_Define.h" 9 #include "../../include/javascript/JS_Define.h"
10 #include "../../include/javascript/JS_Object.h" 10 #include "../../include/javascript/JS_Object.h"
(...skipping 20 matching lines...) Expand all
31 IMPLEMENT_JS_CLASS(CJS_Console,console) 31 IMPLEMENT_JS_CLASS(CJS_Console,console)
32 32
33 console::console(CJS_Object* pJSObject): CJS_EmbedObj(pJSObject) 33 console::console(CJS_Object* pJSObject): CJS_EmbedObj(pJSObject)
34 { 34 {
35 } 35 }
36 36
37 console::~console() 37 console::~console()
38 { 38 {
39 } 39 }
40 40
41 FX_BOOL console::clear(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Valu e& vRet, CFX_WideString& sError) 41 bool console::clear(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
42 { 42 {
43 » return TRUE; 43 » return true;
44 } 44 }
45 45
46 FX_BOOL console::hide(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value & vRet, CFX_WideString& sError) 46 bool console::hide(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& v Ret, CFX_WideString& sError)
47 { 47 {
48 » return TRUE; 48 » return true;
49 } 49 }
50 50
51 FX_BOOL console::println(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Va lue& vRet, CFX_WideString& sError) 51 bool console::println(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value & vRet, CFX_WideString& sError)
52 { 52 {
53 if (params.size() < 1) 53 if (params.size() < 1)
54 { 54 {
55 » » return FALSE; 55 » » return false;
56 } 56 }
57 » return TRUE; 57 » return true;
58 } 58 }
59 59
60 FX_BOOL console::show(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value & vRet, CFX_WideString& sError) 60 bool console::show(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& v Ret, CFX_WideString& sError)
61 { 61 {
62 » return TRUE; 62 » return true;
63 } 63 }
64 64
65 65
66 66
OLDNEW
« no previous file with comments | « fpdfsdk/src/javascript/color.cpp ('k') | fpdfsdk/src/javascript/event.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698