FX_BOOL considered harmful, part 2.

fpdfsdk/src/fpdfview.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../core/include/fxcodec/fx_codec.h"
 #include "../../core/include/fxcrt/fx_safe_types.h"
 #include "../../public/fpdf_ext.h"
 #include "../../public/fpdf_progressive.h"
 #include "../../public/fpdfview.h"
 #include "../../third_party/base/nonstd_unique_ptr.h"
 #include "../../third_party/base/numerics/safe_conversions_impl.h"
 #include "../include/fsdk_define.h"
 #include "../include/fsdk_mgr.h"
 #include "../include/fsdk_rendercontext.h"
 
 CPDF_CustomAccess::CPDF_CustomAccess(FPDF_FILEACCESS* pFileAccess)
 {
     if (pFileAccess)
         m_FileAccess = *pFileAccess;
 }
 
-FX_BOOL CPDF_CustomAccess::ReadBlock(void* buffer, FX_FILESIZE offset, size_t size)
+bool CPDF_CustomAccess::ReadBlock(void* buffer, FX_FILESIZE offset, size_t size)
 {
     if (offset < 0) {
-        return FALSE;
+        return false;
     }
     FX_SAFE_FILESIZE newPos = pdfium::base::checked_cast<FX_FILESIZE, size_t>(size);
     newPos += offset;
     if (!newPos.IsValid() || newPos.ValueOrDie() > m_FileAccess.m_FileLen) {
-        return FALSE;
+        return false;
     }
     return m_FileAccess.m_GetBlock(m_FileAccess.m_Param, offset,(uint8_t*) buffer, size);
 }
 
 //0 bit: FPDF_POLICY_MACHINETIME_ACCESS
 static FX_DWORD foxit_sandbox_policy = 0xFFFFFFFF;
 
 void FSDK_SetSandBoxPolicy(FPDF_DWORD policy, FPDF_BOOL enable)
 {
     switch(policy)
     {
     case FPDF_POLICY_MACHINETIME_ACCESS:
         {
             if(enable)
                 foxit_sandbox_policy |= 0x01;
             else
                 foxit_sandbox_policy &= 0xFFFFFFFE;
         }
         break;
     default:
         break;
     }
 }
 
 FPDF_BOOL FSDK_IsSandBoxPolicyEnabled(FPDF_DWORD policy)
 {
     switch(policy)
     {
     case FPDF_POLICY_MACHINETIME_ACCESS:
-        return (foxit_sandbox_policy & 0x01) ? TRUE : FALSE;
+        return (foxit_sandbox_policy & 0x01) ? true : false;
     default:
-        return FALSE;
+        return false;
     }
 }
 
 #ifndef _T
 #define _T(x) x
 #endif
 
 CCodec_ModuleMgr* g_pCodecModule = nullptr;
 
 #if _FX_OS_ == _FX_LINUX_EMBEDDED_
 class CFontMapper : public IPDF_FontMapper
 {
 public:
     CFontMapper();
     virtual ~CFontMapper();
 
     virtual FT_Face FindSubstFont(
                             CPDF_Document* pDoc,                // [IN] The PDF document
                             const CFX_ByteString& face_name,    // [IN] Original name
-                            FX_BOOL bTrueType,                  // [IN] TrueType or Type1
+                            bool bTrueType,                  // [IN] TrueType or Type1
                             FX_DWORD flags,                     // [IN] PDF font flags (see PDF Reference section 5.7.1)
                             int font_weight,                    // [IN] original font weight. 0 for not specified
                             int CharsetCP,                      // [IN] code page for charset (see Win32 GetACP())
-                            FX_BOOL bVertical,
+                            bool bVertical,
                             CPDF_SubstFont* pSubstFont          // [OUT] Subst font data
                         );
 
     FT_Face m_SysFace;
 };
 
 CFontMapper* g_pFontMapper = NULL;
 #endif      // #if _FX_OS_ == _FX_LINUX_EMBEDDED_
 
 DLLEXPORT void STDCALL FPDF_InitLibrary()
@@ skipping 85 matching lines @@
 
 extern void CheckUnSupportError(CPDF_Document * pDoc, FX_DWORD err_code);
 
 class CMemFile final: public IFX_FileRead
 {
 public:
     CMemFile(uint8_t* pBuf, FX_FILESIZE size):m_pBuf(pBuf),m_size(size) {}
 
     virtual void            Release() {delete this;}
     virtual FX_FILESIZE     GetSize() {return m_size;}
-    virtual FX_BOOL         ReadBlock(void* buffer, FX_FILESIZE offset, size_t size)
+    virtual bool         ReadBlock(void* buffer, FX_FILESIZE offset, size_t size)
     {
             if (offset < 0) {
-                return FALSE;
+                return false;
             }
             FX_SAFE_FILESIZE newPos = pdfium::base::checked_cast<FX_FILESIZE, size_t>(size);
             newPos += offset;
             if (!newPos.IsValid() || newPos.ValueOrDie() > (FX_DWORD)m_size) {
-                return FALSE;
+                return false;
             }
         FXSYS_memcpy(buffer, m_pBuf+offset, size);
-        return TRUE;
+        return true;
     }
 private:
     uint8_t* m_pBuf;
     FX_FILESIZE m_size;
 };
 DLLEXPORT FPDF_DOCUMENT STDCALL FPDF_LoadMemDocument(const void* data_buf, int size, FPDF_BYTESTRING password)
 {
     CPDF_Parser* pParser = new CPDF_Parser;
     pParser->SetPassword(password);
     CMemFile* pMemFile = new CMemFile((uint8_t*)data_buf, size);
@@ skipping 21 matching lines @@
         return NULL;
     }
     CPDF_Document * pDoc = NULL;
     pDoc = pParser?pParser->GetDocument():NULL;
     CheckUnSupportError(pDoc, err_code);
     return pParser->GetDocument();
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDF_GetFileVersion(FPDF_DOCUMENT doc, int* fileVersion)
 {
-    if(!doc||!fileVersion) return FALSE;
+    if(!doc||!fileVersion) return false;
     *fileVersion = 0;
     CPDF_Document* pDoc = (CPDF_Document*)doc;
     CPDF_Parser* pParser = (CPDF_Parser*)pDoc->GetParser();
     if(!pParser)
-        return FALSE;
+        return false;
     *fileVersion = pParser->GetFileVersion();
-    return TRUE;
+    return true;
 }
 
 // jabdelmalek: changed return type from FX_DWORD to build on Linux (and match header).
 DLLEXPORT unsigned long STDCALL FPDF_GetDocPermissions(FPDF_DOCUMENT document)
 {
     if (document == NULL) return 0;
     CPDF_Document*pDoc = (CPDF_Document*)document;
     CPDF_Parser* pParser =  (CPDF_Parser*)pDoc->GetParser();
     CPDF_Dictionary* pDict = pParser->GetEncryptDict();
     if (pDict == NULL) return (FX_DWORD)-1;
@@ skipping 60 matching lines @@
                         int rotate, int flags)
 {
     if (page==NULL) return;
     CPDF_Page* pPage = (CPDF_Page*)page;
 
     CRenderContext* pContext = new CRenderContext;
     pPage->SetPrivateData((void*)1, pContext, DropContext);
 
 #ifndef _WIN32_WCE
     CFX_DIBitmap* pBitmap = NULL;
-    FX_BOOL bBackgroundAlphaNeeded=FALSE;
+    bool bBackgroundAlphaNeeded=false;
     bBackgroundAlphaNeeded = pPage->BackgroundAlphaNeeded();
     if (bBackgroundAlphaNeeded)
     {
 
         pBitmap = new CFX_DIBitmap;
         pBitmap->Create(size_x, size_y, FXDIB_Argb);
         pBitmap->Clear(0x00ffffff);
 #ifdef _SKIA_SUPPORT_
         pContext->m_pDevice = new CFX_SkiaDevice;
         ((CFX_SkiaDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)pBitmap);
 #else
         pContext->m_pDevice = new CFX_FxgeDevice;
         ((CFX_FxgeDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)pBitmap);
 #endif
     }
     else
         pContext->m_pDevice = new CFX_WindowsDevice(dc);
 
     FPDF_RenderPage_Retail(pContext, page, start_x, start_y, size_x, size_y,
-                           rotate, flags, TRUE, NULL);
+                           rotate, flags, true, NULL);
 
     if (bBackgroundAlphaNeeded)
     {
         if (pBitmap)
         {
             CFX_WindowsDevice WinDC(dc);
 
             if (WinDC.GetDeviceCaps(FXDC_DEVICE_CLASS) == FXDC_PRINTER)
             {
                 CFX_DIBitmap* pDst = new CFX_DIBitmap;
                 int pitch = pBitmap->GetPitch();
                 pDst->Create(size_x, size_y, FXDIB_Rgb32);
                 FXSYS_memset(pDst->GetBuffer(), -1, pitch*size_y);
-                pDst->CompositeBitmap(0, 0, size_x, size_y, pBitmap, 0, 0, FXDIB_BLEND_NORMAL, NULL, FALSE, NULL);
+                pDst->CompositeBitmap(0, 0, size_x, size_y, pBitmap, 0, 0, FXDIB_BLEND_NORMAL, NULL, false, NULL);
                 WinDC.StretchDIBits(pDst,0,0,size_x,size_y);
                 delete pDst;
             }
             else
                 WinDC.SetDIBits(pBitmap,0,0);
 
         }
     }
 #else
     // get clip region
@@ skipping 105 matching lines @@
     if (bitmap == NULL || page == NULL) return;
     CPDF_Page* pPage = (CPDF_Page*)page;
 
 
     CRenderContext* pContext = new CRenderContext;
     pPage->SetPrivateData((void*)1, pContext, DropContext);
 #ifdef _SKIA_SUPPORT_
     pContext->m_pDevice = new CFX_SkiaDevice;
 
     if (flags & FPDF_REVERSE_BYTE_ORDER)
-        ((CFX_SkiaDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)bitmap,0,TRUE);
+        ((CFX_SkiaDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)bitmap,0,true);
     else
         ((CFX_SkiaDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)bitmap);
 #else
     pContext->m_pDevice = new CFX_FxgeDevice;
 
     if (flags & FPDF_REVERSE_BYTE_ORDER)
-        ((CFX_FxgeDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)bitmap,0,TRUE);
+        ((CFX_FxgeDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)bitmap,0,true);
     else
         ((CFX_FxgeDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)bitmap);
 #endif
 
     FPDF_RenderPage_Retail(pContext, page, start_x, start_y, size_x, size_y,
-                           rotate, flags, TRUE, NULL);
+                           rotate, flags, true, NULL);
 
     delete pContext;
     pPage->RemovePrivateData((void*)1);
 }
 
 DLLEXPORT void STDCALL FPDF_ClosePage(FPDF_PAGE page)
 {
     if (!page) return;
         CPDFSDK_PageView* pPageView = (CPDFSDK_PageView*)(((CPDF_Page*)page))->GetPrivateData((void*)page);
         if (pPageView && pPageView->IsLocked()) {
@@ skipping 127 matching lines @@
     if (bitmap == NULL) return 0;
     return ((CFX_DIBitmap*)bitmap)->GetPitch();
 }
 
 DLLEXPORT void STDCALL FPDFBitmap_Destroy(FPDF_BITMAP bitmap)
 {
     delete (CFX_DIBitmap*)bitmap;
 }
 
 void FPDF_RenderPage_Retail(CRenderContext* pContext, FPDF_PAGE page, int start_x, int start_y, int size_x, int size_y,
-                            int rotate, int flags,FX_BOOL bNeedToRestore, IFSDK_PAUSE_Adapter * pause )
+                            int rotate, int flags,bool bNeedToRestore, IFSDK_PAUSE_Adapter * pause )
 {
     CPDF_Page* pPage = (CPDF_Page*)page;
     if (pPage == NULL) return;
 
     if (!pContext->m_pOptions)
         pContext->m_pOptions = new CPDF_RenderOptions;
 
     if (flags & FPDF_LCD_TEXT)
         pContext->m_pOptions->m_Flags |= RENDER_CLEARTYPE;
     else
@@ skipping 31 matching lines @@
     clip.bottom = start_y + size_y;
     pContext->m_pDevice->SaveState();
     pContext->m_pDevice->SetClip_Rect(&clip);
 
     pContext->m_pContext = new CPDF_RenderContext;
     pContext->m_pContext->Create(pPage);
     pContext->m_pContext->AppendObjectList(pPage, &matrix);
 
     if (flags & FPDF_ANNOT) {
         pContext->m_pAnnots = new CPDF_AnnotList(pPage);
-        FX_BOOL bPrinting = pContext->m_pDevice->GetDeviceClass() != FXDC_DISPLAY;
-        pContext->m_pAnnots->DisplayAnnots(pPage, pContext->m_pContext, bPrinting, &matrix, TRUE, NULL);
+        bool bPrinting = pContext->m_pDevice->GetDeviceClass() != FXDC_DISPLAY;
+        pContext->m_pAnnots->DisplayAnnots(pPage, pContext->m_pContext, bPrinting, &matrix, true, NULL);
     }
 
     pContext->m_pRenderer = new CPDF_ProgressiveRenderer(
         pContext->m_pContext, pContext->m_pDevice, pContext->m_pOptions);
     pContext->m_pRenderer->Start(pause);
     if (bNeedToRestore)
         pContext->m_pDevice->RestoreState();
 }
 
 DLLEXPORT int STDCALL FPDF_GetPageSizeByIndex(FPDF_DOCUMENT document, int page_index, double* width, double* height)
 {
     CPDF_Document* pDoc = (CPDF_Document*)document;
     if(pDoc == NULL)
-        return FALSE;
+        return false;
 
     CPDF_Dictionary* pDict = pDoc->GetPage(page_index);
-    if (pDict == NULL) return FALSE;
+    if (pDict == NULL) return false;
 
     CPDF_Page page;
     page.Load(pDoc, pDict);
     *width = page.GetPageWidth();
     *height = page.GetPageHeight();
 
-    return TRUE;
+    return true;
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDF_VIEWERREF_GetPrintScaling(FPDF_DOCUMENT document)
 {
     CPDF_Document* pDoc = (CPDF_Document*)document;
-    if (!pDoc) return TRUE;
+    if (!pDoc) return true;
     CPDF_ViewerPreferences viewRef(pDoc);
     return viewRef.PrintScaling();
 }
 
 DLLEXPORT int STDCALL FPDF_VIEWERREF_GetNumCopies(FPDF_DOCUMENT document)
 {
     CPDF_Document* pDoc = (CPDF_Document*)document;
     if (!pDoc) return 1;
     CPDF_ViewerPreferences viewRef(pDoc);
     return viewRef.NumCopies();
@@ skipping 92 matching lines @@
     if (!buffer) {
         *buflen = len;
     } else if (*buflen >= len) {
         memcpy(buffer, utf16Name.c_str(), len);
         *buflen = len;
     } else {
         *buflen = -1;
     }
     return (FPDF_DEST)pDestObj;
 }