FX_BOOL considered harmful, part 2.

fpdfsdk/src/fpdfeditpage.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../public/fpdf_edit.h"
 #include "../include/fsdk_define.h"
 
 
@@ skipping 197 matching lines @@
                 || pPage->m_pFormDict->GetElement("Type")->GetDirect()->GetString().Compare("Page"))
         {
                 return NULL;
         }
         return pPage->GetObjectByIndex(index);
 //      return NULL;
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDFPage_HasTransparency(FPDF_PAGE page)
 {
-        if(!page) return FALSE;
+        if(!page) return false;
         CPDF_Page* pPage = (CPDF_Page*)page;
 
         return pPage->BackgroundAlphaNeeded();
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDFPageObj_HasTransparency(FPDF_PAGEOBJECT pageObject)
 {
-        if(!pageObject) return FALSE;
+        if(!pageObject) return false;
         CPDF_PageObject* pPageObj = (CPDF_PageObject*)pageObject;
 
         const CPDF_GeneralStateData* pGeneralState = pPageObj->m_GeneralState;
         int blend_type = pGeneralState ? pGeneralState->m_BlendType : FXDIB_BLEND_NORMAL;
-        if (blend_type != FXDIB_BLEND_NORMAL) return TRUE;
+        if (blend_type != FXDIB_BLEND_NORMAL) return true;
 
         CPDF_Dictionary* pSMaskDict = pGeneralState ? (CPDF_Dictionary*)pGeneralState->m_pSoftMask : NULL;
-        if(pSMaskDict) return TRUE;
+        if(pSMaskDict) return true;
 
         if(pGeneralState && pGeneralState->m_FillAlpha != 1.0f)
-                return TRUE;
+                return true;
 
         if(pPageObj->m_Type == PDFPAGE_PATH)
         {
                 if(pGeneralState && pGeneralState->m_StrokeAlpha != 1.0f)
-                        return TRUE;
+                        return true;
         }
 
         if(pPageObj->m_Type == PDFPAGE_FORM)
         {
                 CPDF_FormObject* pFormObj = (CPDF_FormObject*)pPageObj;
                 if(pFormObj->m_pForm && (pFormObj->m_pForm->m_Transparency & PDFTRANS_ISOLATED))
-                        return TRUE;
+                        return true;
                 if(pFormObj->m_pForm && (!(pFormObj->m_pForm->m_Transparency & PDFTRANS_ISOLATED) && (pFormObj->m_pForm->m_Transparency & PDFTRANS_GROUP)))
-                        return TRUE;
+                        return true;
         }
-        return FALSE;
+        return false;
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDFPage_GenerateContent(FPDF_PAGE page)
 {
         CPDF_Page* pPage = (CPDF_Page*)page;
         if (!pPage || !pPage->m_pFormDict || !pPage->m_pFormDict->KeyExist("Type") || !pPage->m_pFormDict->GetElement("Type")->GetDirect()
                 || pPage->m_pFormDict->GetElement("Type")->GetDirect()->GetString().Compare("Page"))
         {
-                return FALSE;
+                return false;
         }
         CPDF_PageContentGenerate CG(pPage);
         CG.GenerateContent();
 
-        return TRUE;
+        return true;
 }
 
 DLLEXPORT void STDCALL FPDFPageObj_Transform(FPDF_PAGEOBJECT page_object,
                          double a, double b, double c, double d, double e, double f)
 {
         CPDF_PageObject* pPageObj = (CPDF_PageObject*)page_object;
         if(pPageObj == NULL)
                 return;
         CFX_AffineMatrix matrix((FX_FLOAT)a,(FX_FLOAT)b,(FX_FLOAT)c,(FX_FLOAT)d,(FX_FLOAT)e,(FX_FLOAT)f);
         pPageObj->Transform(matrix);
@@ skipping 34 matching lines @@
         if (!pPage || !pPage->m_pFormDict || !pPage->m_pFormDict->KeyExist("Type") || !pPage->m_pFormDict->GetElement("Type")->GetDirect()
                 || pPage->m_pFormDict->GetElement("Type")->GetDirect()->GetString().Compare("Page"))
         {
                 return;
         }
         CPDF_Dictionary* pDict = pPage->m_pFormDict;
         rotate %=4;
 
         pDict->SetAt("Rotate", new CPDF_Number(rotate * 90));
 }