FX_BOOL considered harmful, part 2.

fpdfsdk/src/fpdfdoc.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../include/fsdk_define.h"
 #include "../../public/fpdf_doc.h"
 
 static int THISMODULE = 0;
@@ skipping 190 matching lines @@
 {
     if (!pDict)
         return NULL;
     CPDF_Link link((CPDF_Dictionary*)pDict);
     return link.GetAction().GetDict();
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDFLink_Enumerate(FPDF_PAGE page, int* startPos, FPDF_LINK* linkAnnot)
 {
     if(!page || !startPos || !linkAnnot)
-        return FALSE;
+        return false;
     CPDF_Page* pPage = (CPDF_Page*)page;
     if(!pPage->m_pFormDict)
-        return FALSE;
+        return false;
     CPDF_Array* pAnnots = pPage->m_pFormDict->GetArray("Annots");
     if(!pAnnots)
-        return FALSE;
+        return false;
     for (int i = *startPos; i < (int)pAnnots->GetCount(); i++) {
         CPDF_Dictionary* pDict = (CPDF_Dictionary*)pAnnots->GetElementValue(i);
         if (!pDict || pDict->GetType() != PDFOBJ_DICTIONARY)
             continue;
         if(pDict->GetString(FX_BSTRC("Subtype")).Equal(FX_BSTRC("Link"))) {
             *startPos = i + 1;
             *linkAnnot = (FPDF_LINK)pDict;
-            return TRUE;
+            return true;
         }
     }
-    return FALSE;
+    return false;
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDFLink_GetAnnotRect(FPDF_LINK linkAnnot, FS_RECTF* rect)
 {
     if(!linkAnnot || !rect)
-        return FALSE;
+        return false;
     CPDF_Dictionary* pAnnotDict = (CPDF_Dictionary*)linkAnnot;
     CPDF_Rect rt = pAnnotDict->GetRect(FX_BSTRC("Rect"));
     rect->left = rt.left;
     rect->bottom = rt.bottom;
     rect->right = rt.right;
     rect->top = rt.top;
-    return TRUE;
+    return true;
 }
 
 DLLEXPORT int STDCALL FPDFLink_CountQuadPoints(FPDF_LINK linkAnnot)
 {
     if(!linkAnnot)
         return 0;
     CPDF_Dictionary* pAnnotDict = (CPDF_Dictionary*)linkAnnot;
     CPDF_Array* pArray = pAnnotDict->GetArray(FX_BSTRC("QuadPoints"));
     if (!pArray)
         return 0;
     return pArray->GetCount() / 8;
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDFLink_GetQuadPoints(FPDF_LINK linkAnnot, int quadIndex, FS_QUADPOINTSF* quadPoints)
 {
     if(!linkAnnot || !quadPoints)
-        return FALSE;
+        return false;
     CPDF_Dictionary* pAnnotDict = (CPDF_Dictionary*)linkAnnot;
     CPDF_Array* pArray = pAnnotDict->GetArray(FX_BSTRC("QuadPoints"));
     if (pArray) {
         if (quadIndex < 0 || quadIndex >= (int)pArray->GetCount()/8 || ((quadIndex*8+7) >= (int)pArray->GetCount()))
-            return FALSE;
+            return false;
         quadPoints->x1 = pArray->GetNumber(quadIndex*8);
         quadPoints->y1 = pArray->GetNumber(quadIndex*8+1);
         quadPoints->x2 = pArray->GetNumber(quadIndex*8+2);
         quadPoints->y2 = pArray->GetNumber(quadIndex*8+3);
         quadPoints->x3 = pArray->GetNumber(quadIndex*8+4);
         quadPoints->y3 = pArray->GetNumber(quadIndex*8+5);
         quadPoints->x4 = pArray->GetNumber(quadIndex*8+6);
         quadPoints->y4 = pArray->GetNumber(quadIndex*8+7);
-        return TRUE;
+        return true;
     }
-    return FALSE;
+    return false;
 }
 
 DLLEXPORT unsigned long STDCALL FPDF_GetMetaText(FPDF_DOCUMENT doc, FPDF_BYTESTRING tag,
                                                  void* buffer, unsigned long buflen)
 {
     if (!doc || !tag)
         return 0;
     CPDF_Document* pDoc = (CPDF_Document*)doc;
     // Get info dictionary
     CPDF_Dictionary* pInfo = pDoc->GetInfo();
     if (!pInfo)
         return 0;
     CFX_WideString text = pInfo->GetUnicodeText(tag);
     // Use UTF-16LE encoding
     CFX_ByteString encodedText = text.UTF16LE_Encode();
     unsigned long len = encodedText.GetLength();
     if (buffer && buflen >= len) {
         FXSYS_memcpy(buffer, encodedText.c_str(), len);
     }
     return len;
 }