Remove ExternalArray, derived types, and element kinds

test/cctest/compiler/test-run-properties.cc

Index: test/cctest/compiler/test-run-properties.cc
diff --git a/test/cctest/compiler/test-run-properties.cc b/test/cctest/compiler/test-run-properties.cc
index d4442f7a85d6ddfc6f295b3c9e8ba1e087bd350d..f0055d5c9736190b223b0b29f9f0633cb28a9d71 100644
--- a/test/cctest/compiler/test-run-properties.cc
+++ b/test/cctest/compiler/test-run-properties.cc
@@ -21,16 +21,14 @@ static void TypedArrayLoadHelper(const char* array_type) {
     values_builder.AddFormatted("a[%d] = 0x%08x;", i, kValues[i]);
   }
 
-  // Note that below source creates two different typed arrays with distinct
+  // Note that below source creates two different typed arrays with the same
   // elements kind to get coverage for both access patterns:

[Jarin, 2015/07/27 12:28:34]

The colon does not really make sense and it is not clear what 'both' means here.

[jochen (gone - plz use gerrit), 2015/07/27 12:51:49]

clarified

-  // - IsFixedTypedArrayElementsKind(x)
-  // - IsExternalArrayElementsKind(y)
   const char* source =
       "(function(a) {"
       "  var x = (a = new %sArray(%d)); %s;"
       "  var y = (a = new %sArray(%d)); %s; %%TypedArrayGetBuffer(y);"
       "  if (!%%HasFixed%sElements(x)) %%AbortJS('x');"
-      "  if (!%%HasExternal%sElements(y)) %%AbortJS('y');"
+      "  if (!%%HasFixed%sElements(y)) %%AbortJS('y');"
       "  function f(a,b) {"
       "    a = a | 0; b = b | 0;"
       "    return x[a] + y[b];"
@@ -84,7 +82,7 @@ static void TypedArrayStoreHelper(const char* array_type) {
     values_builder.AddFormatted("a[%d] = 0x%08x;", i, kValues[i]);
   }
 
-  // Note that below source creates two different typed arrays with distinct
+  // Note that below source creates two different typed arrays with the same
   // elements kind to get coverage for both access patterns:
   // - IsFixedTypedArrayElementsKind(x)
   // - IsExternalArrayElementsKind(y)

[Jarin, 2015/07/27 12:28:34]

Same here.

[jochen (gone - plz use gerrit), 2015/07/27 12:51:49]

done

@@ -93,7 +91,7 @@ static void TypedArrayStoreHelper(const char* array_type) {
       "  var x = (a = new %sArray(%d)); %s;"
       "  var y = (a = new %sArray(%d)); %s; %%TypedArrayGetBuffer(y);"
       "  if (!%%HasFixed%sElements(x)) %%AbortJS('x');"
-      "  if (!%%HasExternal%sElements(y)) %%AbortJS('y');"
+      "  if (!%%HasFixed%sElements(y)) %%AbortJS('y');"
       "  function f(a,b) {"
       "    a = a | 0; b = b | 0;"
       "    var t = x[a];"