Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: src/compiler/access-builder.cc

Issue 1254623002: Remove ExternalArray, derived types, and element kinds (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/access-builder.cc
diff --git a/src/compiler/access-builder.cc b/src/compiler/access-builder.cc
index 24701634748a363747cff0d0cc715f386bd723fe..32d14076f3d2f351052ffbfb5eba0a604a59d8ec 100644
--- a/src/compiler/access-builder.cc
+++ b/src/compiler/access-builder.cc
@@ -82,7 +82,8 @@ FieldAccess AccessBuilder::ForFixedArrayLength() {
// static
FieldAccess AccessBuilder::ForExternalArrayPointer() {
Benedikt Meurer 2015/07/27 12:28:01 Nit: Please remove this method; it is unused anywa
jochen (gone - plz use gerrit) 2015/07/27 12:51:49 done
- FieldAccess access = {kTaggedBase, ExternalArray::kExternalPointerOffset,
+ FieldAccess access = {kTaggedBase,
+ FixedTypedArrayBase::kExternalPointerOffset,
MaybeHandle<Name>(), Type::UntaggedPointer(), kMachPtr};
return access;
}
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/compiler/js-typed-lowering.cc » ('j') | src/factory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698